From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DB38946970F
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 Nov 2019 01:31:00 +0300 (MSK)
References: <d94acc61e0dd96b3365281635c94dc85d19ff31e.1574721619.git.v.shpilevoy@tarantool.org>
 <20191126234926.qmjts444lttinxki@tkn_work_nb>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <e475eb98-ad98-725d-fba9-e361cf262773@tarantool.org>
Date: Wed, 27 Nov 2019 23:30:59 +0100
MIME-Version: 1.0
In-Reply-To: <20191126234926.qmjts444lttinxki@tkn_work_nb>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/1] test: fix flaky
	replication/gh-* tests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

On 27/11/2019 00:49, Alexander Turenko wrote:
> There are more such tests, let's check it youself:
> 
> $ diff -u \
>   <(grep -R cleanup_cluster    test/replication/*.test.lua | cut -d: -f1 | sort -u) \
>   <(grep -R rpl_master=default test/replication/*.test.lua | cut -d: -f1 | sort -u) \
>   | grep ^[+-]test
> 
> +test/replication/consistent.test.lua

This test is disabled. It makes no sense to change it now, if it
is broken anyway.

> +test/replication/errinj.test.lua
> +test/replication/transaction.test.lua

Yes, these ones lack cluster cleanup.

> +test/replication/gh-4402-info-errno.test.lua
> +test/replication/gh-4605-empty-password.test.lua
> +test/replication/gh-4606-admin-creds.test.lua

These three I fixed in my patch.

But whatever. Seems like you have already committed your
fix, so there is nothing to discuss.