From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A93496EC55; Thu, 15 Jul 2021 15:00:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A93496EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1626350417; bh=U8TOR8jjjUu2RPoQUwYjZBcQyFSyOEEC4ZGR2nPHQZ4=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=mzVg8XeBdl00u6xMiZ6L34miXmueT8ycRO1wOUYwnFAHBOR9mBVzmSCOLFtyoheF/ OltnY+RdMtBgJT0Pno3drgoQeJDymwYpZr+H8gvfzH54OFGAdhlrKEStzacR8Sqk35 47S1B0SudtLcKenp+Kh4p5BoekokJXBHx7yfgcEA= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E59716EC55 for ; Thu, 15 Jul 2021 15:00:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E59716EC55 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1m402G-0002BH-5g; Thu, 15 Jul 2021 15:00:12 +0300 To: Cyrill Gorcunov Cc: tml , Vladislav Shpilevoy References: <20210714212328.701280-1-gorcunov@gmail.com> <20210714212328.701280-4-gorcunov@gmail.com> <76124bb2-95fa-5312-e9ae-8c25c527bca2@tarantool.org> Message-ID: Date: Thu, 15 Jul 2021 15:00:11 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C38DCC94ADF53B46036ECF04D6E32A6D03182A05F538085040F7979468A432C6CA6E8D9DA563DEBF9C5444A343916A1D9F36A2F779C0CC3B35 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D43AAFBA4462143CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373CF509324F67ED188638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B4C9457EB67F5AC93CDD204397CB0EBF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6753C3A5E0A5AB5B7089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A574C175D640AB088FFD1D1F9193FBC74617F040483125AA36D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348D68DCC07DD06FF5BC69CF1DB7CDADB9DC25FBB424BCB08CE68998324F20EAA2E2FE993C219B1BB01D7E09C32AA3244C46D5B2B20A0E30EAC762F8DE9BD161727C0C08F7987826B9FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojSyb42jm8PHIgzHcJXSzgCw== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A44666130B3B43BDF230BEBF2E9F8064C2BCC656B243789B01BE424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [RFC v5 3/5] limbo: gather promote tracking into a separate structure X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 15.07.2021 14:46, Cyrill Gorcunov пишет: > On Thu, Jul 15, 2021 at 02:28:46PM +0300, Serge Petrenko wrote: >>> +static void >>> +txn_limbo_promote_create(struct txn_limbo_promote *pmt) >>> +{ >>> + vclock_create(&pmt->terms_map); >>> + pmt->terms_max = 0; >>> +} >>> + >> I don't like the name (limbo->promote, struct txn_limbo_promote), >> but can't come up with a better one. >> >> The structure doesn't hold a specific promote. It's more like "promote >> history", or "terms seen". >> >> Maybe something like "term history" ? "term tracker" ? >> "remote term set", "term set" ? >> >> Just a suggestion, my names are not too good. > Sure! How about > > struct txn_terms { > latch lock; > vclock_t map; > uint64_t map_max; > }; Maybe txn_limbo_terms then? txn_terms sounds like something related to transactions, but transactions know nothing of terms. > struct txn_limbo { > ... > struct txn_terms terms; > ... > }; > > I don't mind for any name (except "set" because > set can't contain duplicated elements and our > vclock can have same term installed for different > replicas) > > Cyrill -- Serge Petrenko