From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 571FF4696C6 for ; Fri, 14 Feb 2020 01:50:23 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: Date: Thu, 13 Feb 2020 23:50:21 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/3] lua: table fixes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: olegrok@tarantool.org, tarantool-patches@dev.tarantool.org, imun@tarantool.org Cc: Oleg Babin Hi! Thanks for the patch! On 13/02/2020 21:33, olegrok@tarantool.org wrote: > From: Oleg Babin > > This patchset fixes three problems. > Two first are bugs in table.deepcopy function. > The third is similar to the second > (because the root of problem is a __pairs > metamethod) that I found then worked on the > second commit. > > Branch: https://github.com/tarantool/tarantool/tree/olegrok/table-fixes Usually we put issue number into branch name. Take a look at branch list on GitHub for examples. Also you need to put web links at the affected issues here. Additionally, we have a new rule, that behaviour changing tickets should be reflected in changelog. This ticket changes behaviour. So you need to add a changelog label. Like this: @ChangeLog - table.deepcopy now correctly handles __metatable attribute of a metatable (gh-4340). I was also thinking about adding a docbot request, but seems like table.* extensions are not documented anyway. > > Oleg Babin (3): > lua: fix incorrect table.deepcopy __metatable handling > lua: table.deepcopy ignores __pairs metamethod > tap: is_deeply ignores __pairs metamethod > > src/lua/table.lua | 9 ++++++-- > src/lua/tap.lua | 9 +++++--- > test/app-tap/table.test.lua | 44 ++++++++++++++++++++++++++++++++++++- > test/app-tap/tap.result | 6 +++-- > test/app-tap/tap.test.lua | 24 +++++++++++++++++++- > 5 files changed, 83 insertions(+), 9 deletions(-) >