From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A9FB62289E for ; Mon, 28 May 2018 10:59:39 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TzkqcextF9-x for ; Mon, 28 May 2018 10:59:39 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 01AEE21CB6 for ; Mon, 28 May 2018 10:59:38 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v7 6/7] sql: export funcs defined on Expr, ExprList to sql.h References: <26d7bf8070e9e573eb61897c34bf027a52eb8d66.1527084287.git.kshcherbatov@tarantool.org> <809edd89-13dc-3039-d8e0-964a202bc8f6@tarantool.org> From: Kirill Shcherbatov Message-ID: Date: Mon, 28 May 2018 17:59:35 +0300 MIME-Version: 1.0 In-Reply-To: <809edd89-13dc-3039-d8e0-964a202bc8f6@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: "v.shpilevoy@tarantool.org" >> 1. Please, do not put extra white space after *. > 2. Still not fixed. diff --git a/src/box/sql.h b/src/box/sql.h index a02d156..c4d76a7 100644 --- a/src/box/sql.h +++ b/src/box/sql.h @@ -191,7 +191,7 @@ sql_table_def_rebuild(struct sqlite3 *db, struct Table *table); * @retval not NULL on success. */ struct ExprList * -sql_expr_list_dup(struct sqlite3 *db, struct ExprList * p, int flags); +sql_expr_list_dup(struct sqlite3 *db, struct ExprList *p, int flags); /** * Free AST pointed by expr list. diff --git a/src/box/sql/expr.c b/src/box/sql/expr.c index cc3278b..d8c6c87 100644 --- a/src/box/sql/expr.c +++ b/src/box/sql/expr.c @@ -1447,7 +1447,7 @@ sqlite3ExprDup(sqlite3 * db, Expr * p, int flags) } struct ExprList * -sql_expr_list_dup(struct sqlite3 * db, struct ExprList *p, int flags) +sql_expr_list_dup(struct sqlite3 *db, struct ExprList *p, int flags) { struct ExprList_item *pItem, *pOldItem; int i; > 3. Why did you ignore part of comment 7 from the previous review? -sql_expr_list_append(struct sqlite3 * db, struct ExprList *expr_list, +sql_expr_list_append(struct sqlite3 *db, struct ExprList *expr_list, struct Expr *expr)