From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9E21E469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  3 Jun 2020 10:01:38 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <20200602221817.645015-1-gorcunov@gmail.com>
 <20200602221817.645015-9-gorcunov@gmail.com>
Message-ID: <e32ef2a1-a0b4-4962-efd3-794cf1a39da8@tarantool.org>
Date: Wed, 3 Jun 2020 10:01:36 +0300
MIME-Version: 1.0
In-Reply-To: <20200602221817.645015-9-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v8 08/12] lua/log: allow to
 configure logging without a box
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi! Thanks for your patch. I left one little comment below.
After that LGTM. We've discussed privately that configuration subsystem 
should be reworked but anyway it should be done in scope of separate task.

On 03/06/2020 01:18, Cyrill Gorcunov wrote:
> We bring in an ability to configure logger early without
> calling box.cfg{}. For this sake log.cfg({}) becomes a
> callable table. One can provide arguments of the looger

typo: looger -> logger