From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>, olegrok@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 3/3] fiber: keep reference to userdata if fiber created once
Date: Sun, 5 Sep 2021 17:07:07 +0200 [thread overview]
Message-ID: <e2d422b6-e889-76d8-aae8-b547db522878@tarantool.org> (raw)
In-Reply-To: <20210903122314.GV5743@tarantool.org>
>> diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
>> index 588b78504..39b67f940 100644
>> --- a/src/lib/core/fiber.c
>> +++ b/src/lib/core/fiber.c
>> @@ -32,6 +32,7 @@
>>
>> #include <trivia/config.h>
>> #include <trivia/util.h>
>> +#include <lauxlib.h>
>
> Totally agree with Vlad here. I guess you have two options:
> * Use the approach similar to <cord_on_yield>.
> * Introduce a constant in src/lib/core/fiber.h and add a static assert
> in src/lua/utils.h whether this value is the same as in LuaJIT.
>
> Maybe there are other options Vlad can suggest.
I have no better ideas. But among these 2 the one with a constant in
fiber.h and a static assert looks better. Less dependencies.
prev parent reply other threads:[~2021-09-05 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 18:13 [Tarantool-patches] [PATCH v2 0/3] " Oleg Babin via Tarantool-patches
2021-09-02 18:13 ` [Tarantool-patches] [PATCH v2 1/3] fiber: rename ref to storage_ref Oleg Babin via Tarantool-patches
2021-09-02 18:13 ` [Tarantool-patches] [PATCH v2 2/3] fiber: pass struct fiber into lbox_pushfiber instead of id Oleg Babin via Tarantool-patches
2021-09-02 18:13 ` [Tarantool-patches] [PATCH v2 3/3] fiber: keep reference to userdata if fiber created once Oleg Babin via Tarantool-patches
2021-09-02 19:47 ` Oleg Babin via Tarantool-patches
2021-09-03 12:23 ` Igor Munkin via Tarantool-patches
2021-09-03 20:48 ` Oleg Babin via Tarantool-patches
2021-09-05 15:07 ` Vladislav Shpilevoy via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2d422b6-e889-76d8-aae8-b547db522878@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 3/3] fiber: keep reference to userdata if fiber created once' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox