From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 27A19240D4
	for <tarantool-patches@freelists.org>; Mon, 23 Jul 2018 09:45:19 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 0cq2wn_Wi219 for <tarantool-patches@freelists.org>;
	Mon, 23 Jul 2018 09:45:19 -0400 (EDT)
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DAB1D23D3B
	for <tarantool-patches@freelists.org>; Mon, 23 Jul 2018 09:45:18 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 2/4] Complete module reload
References: <cover.1532344375.git.avkhatskevich@tarantool.org>
 <6ebbf656cf54e40298ffa067551c291beefd1f8c.1532344376.git.avkhatskevich@tarantool.org>
 <0047207a-712a-1d14-31d3-decf63608719@tarantool.org>
From: Alex Khatskevich <avkhatskevich@tarantool.org>
Message-ID: <e2a4e64e-946b-1837-5d86-f3a572f516b0@tarantool.org>
Date: Mon, 23 Jul 2018 16:45:16 +0300
MIME-Version: 1.0
In-Reply-To: <0047207a-712a-1d14-31d3-decf63608719@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@freelists.org



On 23.07.2018 16:31, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
>> diff --git a/vshard/replicaset.lua b/vshard/replicaset.lua
>> index 99f59aa..6c8d477 100644
>> --- a/vshard/replicaset.lua
>> +++ b/vshard/replicaset.lua
>> @@ -21,6 +21,7 @@
>>   --                                  requests to the replica>,
>>   --             net_sequential_fail = <count of sequential failed
>>   --                                    requests to the replica>,
>> +--             is_outdated = nil/true,
>
> https://github.com/tarantool/vshard/blob/kh/gh-112-reload-mt-2/vshard/replicaset.lua#L24 
>
>
> Looks like the version on the branch actually is outdated
> instead of the replica object. Please, push the latest
> version.
Sorry. Pushed.