From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 97F4F6EC5F; Fri, 30 Apr 2021 23:45:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 97F4F6EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619815538; bh=lXRaHup/ZmIk7C6RKncFW3bdNDufyLqkum4TVvQsIl0=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RwwuvpOI3I6sfDad5W1YgqGzUdaryVFgj6uYqaaYXpsvkRR4T8VrJZ24OzWo9lQMt GA5lQSdGHE4zmgPdWIs39XtLVXd8rRkbeXzkI0bzdCBVy1l5/gPncMJxvVmo2+i5eX XlBVUs1MNzZISknQiaO/IBFFcGc5aY80yamVBXt4= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D9C2A6EC5F for ; Fri, 30 Apr 2021 23:45:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D9C2A6EC5F Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1lca12-00012q-KX; Fri, 30 Apr 2021 23:45:36 +0300 To: Cyrill Gorcunov , tml References: <20210430153940.121271-1-gorcunov@gmail.com> Message-ID: Date: Fri, 30 Apr 2021 22:45:35 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210430153940.121271-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95978C26455E69BE022900C3053DBED7681036D2C478A411E182A05F538085040263C16E6A2550B1011EE9F381187A608D9066076B169872124DCDCD5E82C0DA3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CC84CC3AD347B910EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E31772672C957B658638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2CC6894F7003DBD867C7E895D45E5B86B44A6ACC89FD899E7D2E47CDBA5A96583C09775C1D3CA48CFE97D2AE7161E217F117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7850F8B975A76562C9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7D332905FD156B925D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C04179FB555EAE61CACD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4ADAC16E8A1BF356EE972805EB14FB00CD4 X-C1DE0DAB: 0D63561A33F958A530C9F829AB460D193E3B560754E52205F62C4F427740AE64D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343C45ADCD169245FA657884335273188FC9B681FA5221604436427F7E6D50672DD564599E4999834F1D7E09C32AA3244CA5CD2B0633DA20F51CB357BC08278B3530452B15D76AEC1483B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9hvEon6tehPQXVmnwQ1pHg== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110C7DC377089BD06F0BD511F987684446DC688BF8F911ED68407784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [RFC v3 0/3] relay: provide downstream lag information X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: Mons Anderson Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patchset! > Please take a look on applier notifications structure and naming. Actually > I don't really like `downstream.lag` name either because this is not a counterpart > for `upstream.lag` as far as I understand but rather packet traverse so maybe > `dowstream.wal-lag` would be more suitable? Also in idle cycles downstream.lag For me 'downstream.lag' looks good. `wal-lag` looks bad, because you will need to take this name into quotes to use it in Lua instead of indexing via '.'. But another option would be 'downstream.latency'. > is not changed which might confuse the readers because `upstream.lag` does. This is indeed not good. Should be fixed somehow. If there are no rows to ACK, it could be dropped to 0, for example. Also you could use relay heartbeat timestamps on the applier side to report just network latency (since there are no rows to write to WAL).