From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C8C9E469719 for ; Sat, 29 Feb 2020 20:10:11 +0300 (MSK) References: <20200226082029.GA5040@atlas> <352307e9-cc71-2f26-8beb-148a3e0cd3de@tarantool.org> <20200227065325.GF29715@atlas> From: Vladislav Shpilevoy Message-ID: Date: Sat, 29 Feb 2020 18:10:10 +0100 MIME-Version: 1.0 In-Reply-To: <20200227065325.GF29715@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32 List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , tarantool-patches@dev.tarantool.org, olegrok@tarantool.org On 27/02/2020 07:53, Konstantin Osipov wrote: > * Vladislav Shpilevoy [20/02/27 09:42]: >>> * Vladislav Shpilevoy [20/02/26 09:31]: >>>> Closes #207 >>> >>> While you're at it, is this hardware crc32? >> >> Yes, this is hardware, when possible. And it is in C. See crc32.c >> files (there are two of them). > > I mean the entire method could be in C, including building a > msgpack string from cdata. But how building MessagePack is related to crc32? We will need to do that in C anyway. Now I am doing that via msgpackffi, which is fast enough. So in both cases we have MessagePack building, 1 Lua C call, and optimal crc32 calculation in C.