From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4EFC0283A9
	for <tarantool-patches@freelists.org>; Mon, 22 Apr 2019 06:43:29 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1Zt-wGUMUcAM for <tarantool-patches@freelists.org>;
	Mon, 22 Apr 2019 06:43:29 -0400 (EDT)
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 034F6283A4
	for <tarantool-patches@freelists.org>; Mon, 22 Apr 2019 06:43:28 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH] sql: modify TRIM() function
 signature
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
References: <20190411173326.36120-1-roman.habibov@tarantool.org>
 <07e149a4-679a-53f1-ccf9-78219cc0ec47@tarantool.org>
 <D522318E-9237-4A00-8915-4A8D970B5770@tarantool.org>
 <49c88b8e-95ff-1a37-9ec3-fc16597891e3@tarantool.org>
 <16D82235-D881-4AC2-AB80-E12344E33CD7@tarantool.org>
 <2f3fd95d-228e-4d76-e067-8297bd91afb4@tarantool.org>
 <14F67DBB-9F0B-4965-A5A2-04E639614265@tarantool.org>
 <c52ef274-de0a-e6af-27fe-d063b4091223@tarantool.org>
Message-ID: <e21e7eda-1e41-8a3d-3f6c-6f90410fa80c@tarantool.org>
Date: Mon, 22 Apr 2019 13:43:26 +0300
MIME-Version: 1.0
In-Reply-To: <c52ef274-de0a-e6af-27fe-d063b4091223@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Roman Khabibov <roman.habibov@tarantool.org>, tarantool-patches@freelists.org


>>>> + */
>>>> +static void
>>>> +trim_func_one_arg(sql_context * context, int argc, sql_value **argv)
>>>
>>> 13. In new code we use explicit 'struct' keyword for struct
>>> types - sql_context and sql_value. Also, we do not put whitepaces
> 
> 5. Note, I said 'sql_value' too, and look at your code below. What
> have you missed?

Sorry, now I see that sql_value is a typedef and can not be prepended
with struct.