From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 029AE4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Apr 2020 12:10:51 +0300 (MSK)
References: <2d94d49b51bd326d79a032cdfe0307480b2f5475.1586097801.git.lvasiliev@tarantool.org>
 <cbdb690e-7368-08ad-1bc8-fb387f3a2bdb@tarantool.org>
From: lvasiliev <lvasiliev@tarantool.org>
Message-ID: <e2034e97-a3bf-d9f1-cbf1-7da84fd9a6ad@tarantool.org>
Date: Fri, 10 Apr 2020 12:10:50 +0300
MIME-Version: 1.0
In-Reply-To: <cbdb690e-7368-08ad-1bc8-fb387f3a2bdb@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2] rocks: forward options to
	luarocks
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: Yaroslav Dynnikov <Yaroslav.dynnikov@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi.Thanks for the feedback.
I updated the comment.

commit 28a3b55fbc94c10b284201955e8030de75e03f3f
Author: Leonid <lvasiliev@tarantool.org>
Date:   Fri Nov 15 15:36:33 2019 +0300

     rocks: forward options to luarocks

     The policy for check of luarocks flags has been changed
     (moved from tarantoolctl to luarocks).
     Chdir has been moved to luarocks.
     Unsupported flags have been deleted from luarocks

     @TarantoolBot document
     Title: Update tarantoolctl rocks
     tarantoolctl rocks commands has been added:
     build
     config
     download
     init
     lint
     new_version
     purge
     which
     write_rockspec

     https://github.com/luarocks/luarocks/wiki/luarocks

     Closes #4629


On 10.04.2020 3:00, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> I added Yaroslav to CC since he expressed a will to join the
> review.
> 
> On 05/04/2020 16:49, Leonid Vasiliev wrote:
>> From: Leonid <lvasiliev@tarantool.org>
>>
>> The policy for check of luarocks flags has been changed (moved from tarantoolctl to luarocks).
> 
> Usually there is a high tolerance to too long commit
> message lines, but this is outstanding. Please, try to
> keep it in 80 symbols top, 66 best.
> 
>> We had a white-list of luarocks options in tarantoolctl before.
>> Now we have a black-list of options (for tarantool) in luarocks.
> 
> We don't have a blacklist anymore, from what I see. The
> not supported options were just removed from the options
> parser.
> 
>> Help section has been updated.
> 
> It was not.
> 
>> @TarantoolBot document
>> Title: Update tarantoolctl rocks
>> tarantoolctl rocks commands has been added:
>> build
>> config
>> download
>> init
>> lint
>> new_version
>> purge
>> which
>> write_rockspec
> 
> Where a technical writer should take documentation
> on these commands? Their arguments, options? Probably
> there is a link describing all of them?
> 
>> Closes #4629
>> ---
>> https://github.com/tarantool/tarantool/issues/4629
>> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4629-forward-flags