From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EDA42454541; Mon, 5 Jun 2023 17:21:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EDA42454541 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1685974881; bh=ZqAYEwPgVaxeVnWpdGzn0yrauyGoec9tfyYATc/o7gw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LYBL01fbIKswHgC1n471utxRvYLM5sBSFlt024HICKrMZqhBaaWk8OeoosSHFHv+W 0EXF750beNct+lR56JwW3fccHCGZEPau1q2g6+EExauMhROSBdi2Jf3yt/2rOt4/US 6wFRz9ZInQVBGhQZ4U8iGXNIy5n86AbLg2OmO4XE= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B5E91454541 for ; Mon, 5 Jun 2023 17:21:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B5E91454541 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1q6B5C-00DrZK-Qi; Mon, 05 Jun 2023 17:21:19 +0300 Message-ID: Date: Mon, 5 Jun 2023 17:21:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Sergey Kaplun , Igor Munkin , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <848c82043f91fcaa4883c711cfa85bf1a1bc9959.1685613304.git.skaplun@tarantool.org> In-Reply-To: <848c82043f91fcaa4883c711cfa85bf1a1bc9959.1685613304.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD988F25420CCA9469AC4C4DE6D3AF0D4F65E8FFE5E098C4BB3182A05F538085040DE7FA092201FC89C516AA4DE8ABF1C1AEE0A9695DDBBD03D4F76B4743DFA56BD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE768BD42809A772457EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E0B09B181166DBFC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C40ECE75A9083EA34EFF4F7E086F8FF5117882F44604297287769387670735204B6963042765DA4BF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EED76C6ED7039589DE96C9B5BF839F39F6D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3251EFD5447B32ED6AD7EC71F1DB88427C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BC468E7E89D8C5D6EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A593027A4CA4585D42A730DECF74211C9C0D1FCA37B3AA5DBAF87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340A59E724FC7897F7C46AF7F4C629CAF0A36D4CE0E4F8D4F954BD35578537143DB9FDDA35858D39E41D7E09C32AA3244CD2D439BD39C7DE37189407977474886B39C99C45E8D137E9BAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxchphH+YLHxycQEUcQzRRg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769F3091D318244E90A516AA4DE8ABF1C1AF43CCAED39DA92F1EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, thanks for patches and fixes! LGTM with a minor comment below. On 6/5/23 13:41, Sergey Kaplun wrote: > When we set `LUA_TEST_ENV_MORE` variable to be used in the additional > env command for run testing if `"` is used to wrap the `LD_LIBRARY_PATH` > value the content of this environment variable is literally > `"/abs/path1:/abs/path2:...:"`. So, the first entry is treated as the > relative path starting with `"`. In that case if we need the library to > be loaded via FFI for this particular test, that loading fails with the > error "cannot open shared object file", since the path to it is > incorrect. > > This patch removes `"` wrapping for the aforementioned variables. Nit: I would also add a couple of words about how it is related to a whole patchset. Not it is not obvious. As I got it right at least a test "test/tarantool-tests/lj-flush-on-trace.test.lua" fails because it uses "DYLD_LIBRARY_PATH". > --- > test/tarantool-tests/CMakeLists.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index a428d009..38d6ae49 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -102,6 +102,11 @@ endif() > # loaded modules on MacOS instead of shared libraries as it is > # done on Linux and BSD, another environment variable should be > # used to guide while searching the extension. > +# XXX: Be noticed that we shouldn't use `"` here to wrap > +# the variable's content. If we do this, the variable value will > +# contain `"` at the beginning and the end, so this `"` at the > +# beginning will be treated as the directory for the first entry > +# (the last subdirectory added). > if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > # XXX: Apple tries their best to "protect their users from > # malware". As a result SIP (see the link[1] below) has been > @@ -122,9 +127,9 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > # > # [1]: https://support.apple.com/en-us/HT204899 > # [2]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html > - list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH="${LD_LIBRARY_PATH}") > + list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH=${LD_LIBRARY_PATH}) > else() > - list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH="${LD_LIBRARY_PATH}") > + list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH}) > endif() > > # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list