From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B06936FC8F; Sun, 12 Sep 2021 18:44:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B06936FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1631461464; bh=qJSRnOc55qPcOy7FoP7xA2UoW48Tj21RISTNUcv7Klc=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JBnj0lF7roSJ5gnflosg8agtcEAQTqG6WrZwuR9v8qCgtdYtx27Y7Ndt1pEw61lw4 OU31Msi2sGO02XP6Bm1XrNxDR2PNSf2srDSO9n6ZJ3zMYHPDuasy6yB/hGDOUfLZFg 1wIa7rIbphdbRFaKzfNdb5Rs//yR299zJmmWKRJU= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 11C0F6FC8F for ; Sun, 12 Sep 2021 18:44:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 11C0F6FC8F Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mPReD-0005Gd-IN; Sun, 12 Sep 2021 18:44:01 +0300 To: Cyrill Gorcunov , tml References: <20210910152910.607398-1-gorcunov@gmail.com> <20210910152910.607398-2-gorcunov@gmail.com> Message-ID: Date: Sun, 12 Sep 2021 17:44:00 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210910152910.607398-2-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2FF3F790D2CFB1565D68082CE688654CB400894C459B0CD1B967AC8A9056165EE0FA84C342EEB88E3D06C63B2D39B5180C15804A7B4BC5E743 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73C714006C69EB7BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371758572763D318798638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8794F05712883F44D009E2C5DE98DF6E4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCEA77C8EAE1CE44B0A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A55D4D00B7AFA0D32723AE7291EF68C0222B8712C85BBF5E49D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA756665624D6DDF07B5410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34951738D4D62E58A42FCDE10B0C038DA1F14FAC0460D7E8CCDCA78C4359EE485FEB79436C7E7F60571D7E09C32AA3244C7C293384F1E303BCBCC034FB379D6F4269B6CAE0477E908D729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojuaewUBhMl4x6YYA7ivAIrQ== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D222B1F9E6516654028C660C24EC1DB3E3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v14 1/6] qsync: track confirmed lsn number on reads X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 10.09.2021 17:29, Cyrill Gorcunov via Tarantool-patches wrote: > We will use this lsn for requests validation > in next patches for sake of split-brain detection. I don't understand. How exactly will it help? > Part-of #6036 > > Signed-off-by: Cyrill Gorcunov > --- > src/box/txn_limbo.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c > index 70447caaf..cca2ce493 100644 > --- a/src/box/txn_limbo.c > +++ b/src/box/txn_limbo.c > @@ -437,6 +437,13 @@ txn_limbo_read_confirm(struct txn_limbo *limbo, int64_t lsn) > assert(e->txn->signature >= 0); > txn_complete_success(e->txn); > } > + > + /* > + * We use confirmed lsn number to verify requests and > + * reject ones coming from split-brain cluster configurations, > + * so update it even if there were no entries to process. > + */ > + limbo->confirmed_lsn = lsn;