From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 14BAA4C889; Thu, 14 Jan 2021 12:02:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 14BAA4C889 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610614955; bh=+cBlTuuCW47RtqSXLP+swCPM1q1xiIlSoqfhMzO4aOs=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=sTE5rz728AsO0+pZ56ISn63X7DuHWUbO7keAWdX5NcsiFwD9hKUNgjtu/IJEoXu1Q L9+KeKTK2pz/t/TA2mvMyj3+hsixjRIkLKDdZJit5YW1UHYHzQOyM/gQ5mdL4z3tVj O3l3Eoy0nfa7NREBKLrAL5Q3nrP/FxItEHdsqy1E= Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2F2604C885 for ; Thu, 14 Jan 2021 12:02:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F2604C885 Received: by smtp63.i.mail.ru with esmtpa (envelope-from ) id 1kzyWX-0004ew-Bw; Thu, 14 Jan 2021 12:02:33 +0300 To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org Cc: Sergey Bronnikov , alexander.turenko@tarantool.org References: <28dc6d930bc93ece50cce5ba5f37b2eab4bdf50d.1610526975.git.estetus@gmail.com> Message-ID: Date: Thu, 14 Jan 2021 12:02:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <28dc6d930bc93ece50cce5ba5f37b2eab4bdf50d.1610526975.git.estetus@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD3BE40D5FE7B3134676ED03235248932300894C459B0CD1B97581EA8B9211BD91882CE8D28316FE7741B91D94412F7D5989BD80B6B4489A2D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE728F774C865CF4B07EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378010A306A5B6F90A8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC0C6E0E68801B4CDCB4DB89D50B5B4219158D6AEEE1E203FA389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224966D89E201A891B4676E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BB403722D27F53E293AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE73D56AD9F5B48EAD367F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3DB8B71E42BA00C4F35872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9DE2850DD75B2526BE5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A52DA5372B9A427B408FF021E32E577CC188B60412483258B6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3441661D6226BE8C31A55CC88C948747D16BA474393529B5518446DC5ADDF6DC635EAB2B81F7E6F1FE1D7E09C32AA3244C67112997E87D0D48662C92FDB3640720E8FBBEFAE1C4874C927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9kdO2HH36x4NG6+uDSrY1g== X-Mailru-Sender: 48EFD2E18A91C559803250E574CC3D29BF0AC9508B53450A21C058A8EB900DA78A2AC75D222269F8D35D514C7DAC97282D063C67CFD4E84987597EC79699C0E6F21BD4036121A32F7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 2/4] test: fix xlog-py/big_lsn.test.py X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Leonid Vasiliev via Tarantool-patches Reply-To: Leonid Vasiliev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the patch. LGTM. On 13.01.2021 11:48, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > Set correct encoding on opening file. > > Part of #5538 AFAIU, if the task has been closed, new patches corresponding with the task are marked as "Follows up". > --- > test/xlog-py/big_lsn.test.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/test/xlog-py/big_lsn.test.py b/test/xlog-py/big_lsn.test.py > index edc1e5620..73dcf7a48 100644 > --- a/test/xlog-py/big_lsn.test.py > +++ b/test/xlog-py/big_lsn.test.py > @@ -1,4 +1,5 @@ > import os > +import codecs > > # > # Check that Tarantool handles huge LSNs well (gh-4033). > @@ -17,7 +18,7 @@ new_lsn = 123456789123 > wal_dir = os.path.join(server.vardir, server.name) > old_wal = os.path.join(wal_dir, "%020d.xlog" % old_lsn) > new_wal = os.path.join(wal_dir, "%020d.xlog" % new_lsn) > -with open(old_wal, "r+") as f: > +with codecs.open(old_wal, "r+", encoding = "ISO-8859-1") as f: > s = f.read() > s = s.replace("VClock: {{1: {}}}".format(old_lsn), > "VClock: {{1: {}}}".format(new_lsn)) >