From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8C9FB469719 for ; Tue, 3 Nov 2020 13:27:14 +0300 (MSK) References: <20201031162911.61876-1-sergos@tarantool.org> <20201103102018.GC517@tarantool.org> From: Oleg Babin Message-ID: Date: Tue, 3 Nov 2020 13:27:12 +0300 MIME-Version: 1.0 In-Reply-To: <20201103102018.GC517@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH v2] core: handle fiber cancellation for fiber.cond List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Hi! Thanks for your comment and diff. On 03/11/2020 13:20, Sergey Ostanevich wrote: > So, my resolution will be: it is wrong to set a diag in an arbitrary > place, without clear understanting of the reason. This is the case for > the cond_wait machinery, since it doesn't know_why_ the fiber is > cancelled. > > I propose to cover the case with condition on empty diag and call it a > day. Sounds reasonable. It seems to be ok.