From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 963D630C2B
	for <tarantool-patches@freelists.org>; Thu, 13 Jun 2019 18:24:37 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id nS_F1u13rXal for <tarantool-patches@freelists.org>;
	Thu, 13 Jun 2019 18:24:37 -0400 (EDT)
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 55D0330BDB
	for <tarantool-patches@freelists.org>; Thu, 13 Jun 2019 18:24:37 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 25/28] sql: remove sql_log()
References: <cover.1560174553.git.imeevma@gmail.com>
 <f838cc279fa77b18aa91b4785faabf10e61b82c7.1560174553.git.imeevma@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <e09175b6-58bd-c10a-e7dc-9ff175873321@tarantool.org>
Date: Fri, 14 Jun 2019 00:24:53 +0200
MIME-Version: 1.0
In-Reply-To: <f838cc279fa77b18aa91b4785faabf10e61b82c7.1560174553.git.imeevma@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, imeevma@tarantool.org

Thanks for the patch!

Consider my review fixes below and on the branch
in a separate commit.

======================================================

diff --git a/src/box/sql/global.c b/src/box/sql/global.c
index 0bbd8c2fd..c3c7e945c 100644
--- a/src/box/sql/global.c
+++ b/src/box/sql/global.c
@@ -196,8 +196,6 @@ SQL_WSD struct sqlConfig sqlConfig = {
 	0,			/* isInit */
 	0,			/* inProgress */
 	0,			/* isMallocInit */
-	0,			/* xLog */
-	0,			/* pLogArg */
 #ifdef SQL_VDBE_COVERAGE
 	0,			/* xVdbeBranch */
 	0,			/* pVbeBranchArg */
diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
index 097f9730a..9b0928d0a 100644
--- a/src/box/sql/sqlInt.h
+++ b/src/box/sql/sqlInt.h
@@ -2752,8 +2752,6 @@ struct sqlConfig {
 	int isInit;		/* True after initialization has finished */
 	int inProgress;		/* True while initialization in progress */
 	int isMallocInit;	/* True after malloc is initialized */
-	void (*xLog) (void *, int, const char *);	/* Function for logging */
-	void *pLogArg;		/* First argument to xLog() */
 #ifdef SQL_VDBE_COVERAGE
 	/* The following callback (if not NULL) is invoked on every VDBE branch
 	 * operation.  Set the callback using sql_TESTCTRL_VDBE_COVERAGE.