From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BBC5820208 for ; Wed, 25 Jul 2018 16:52:24 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tiDpRfLg-ncF for ; Wed, 25 Jul 2018 16:52:24 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 156F0201F4 for ; Wed, 25 Jul 2018 16:52:24 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/2] sql: use schema API to get index info in analyze References: <5899c7db-b1c0-d099-989e-dcb41b801cdd@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Wed, 25 Jul 2018 23:52:21 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Cc: korablev@tarantool.org Hi! Thanks for the patch, but it is not needed anymore after this commit https://github.com/tarantool/tarantool/commit/0ecabde8981500886bf5be16cfabe4d1d1a33db4. Moreover, we should stop use schema_find_id to get a space since such requests should be filtered through _vspace to prevent unauthorized access to _space. I've opened an issue: https://github.com/tarantool/tarantool/issues/3570 On 24/07/2018 14:05, Kirill Shcherbatov wrote: > We would like to avoid starting transactions in ANALYZE > so we need to use schema API that is more tolerant. > > Part of #3551. > --- > src/box/sql/analyze.c | 82 ++++++++++++++++++++++++++++++--------------------- > 1 file changed, 48 insertions(+), 34 deletions(-) >