From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3E22E46971A
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 14 Dec 2019 23:59:51 +0300 (MSK)
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
References: <20191210083258.GD21413@atlas>
 <2c8fe897-9a9d-849d-463e-5fadff982b8c@tarantool.org>
 <20191211070830.GA5953@atlas>
 <b3c4f4bb-e8fa-8cb1-a54e-6a564b000188@tarantool.org>
 <20191212084603.GA24448@atlas>
 <96368326-84a1-0b3c-15f8-54e3d044db85@tarantool.org>
 <20191213075850.GA21575@atlas>
 <60d9ec76-50be-ecae-175c-520975c928f9@tarantool.org>
 <20191214122644.GA17689@atlas> <20191214123056.GB17689@atlas>
 <20191214123333.GC17689@atlas>
 <67adef62-9767-06f0-32c5-53baa6ad491f@tarantool.org>
Message-ID: <dff913bd-ec15-5700-ee7a-c095b4596eba@tarantool.org>
Date: Sat, 14 Dec 2019 21:59:49 +0100
MIME-Version: 1.0
In-Reply-To: <67adef62-9767-06f0-32c5-53baa6ad491f@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage
 created by iproto
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org

Ok, we discussed the ticket verbally. It was
decided to keep it as is but revert all renames.

Also I will add a doc request in which I will
describe with details when and how fiber storage
behaves. For example, what about triggers, applier.

On 14/12/2019 17:49, Vladislav Shpilevoy wrote:
> Well, I still don't understand what you are keep saying and
> what do you want, and since it does not look like I will, I
> am out of this ticket.
> 
> On 14/12/2019 13:33, Konstantin Osipov wrote:
>> * Konstantin Osipov <kostja.osipov@gmail.com> [19/12/14 15:30]:
>>> I checked now, and Lua addeded debug.getupvalue() to Lua C API.
>>>
>>> On other words, fiber storage now can be implemented in pure Lua,
>>> without any triggers. 
>>>
>>> Back when we were writing, upvalue API was only available in C
>>> API, and AFAIR there was no way to access upvalues from Lua, this
>>> is why we had to come up with this hack.
>>
>> The feature can actually be deprecated. There is now a completely
>> legitimate and easy to use way to have a request-local object with
>> a user defined destructor in pure Lua.
>>
>> If you do want to keep it, you should try to minimized the damage
>> to the core, not extend it.
>>