From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9B187469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 22 Feb 2020 19:29:11 +0300 (MSK)
References: <20200221123203.6956-1-k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <df82a30f-6a15-9e08-ef58-c0879be604d5@tarantool.org>
Date: Sat, 22 Feb 2020 17:28:46 +0100
MIME-Version: 1.0
In-Reply-To: <20200221123203.6956-1-k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] app: verify unix socket path length
 in socket.tcp_server()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

> diff --git a/test/app/socket.result b/test/app/socket.result
> index 9829df138..f47d06935 100644
> --- a/test/app/socket.result
> +++ b/test/app/socket.result
> @@ -1614,6 +1614,14 @@ socket.getaddrinfo('host', 'port', { flags = 'WRONG' }) == nil and errno() == er
>  ---
>  - true
>  ...
> +-- gh-4634: verify socket path length in socket.tcp_server.
> +long_port = string.rep('a', 110)
> +---
> +...
> +socket.tcp_server('unix/', long_port, function(s) end) == errno.ENOBUF

Both function result and errno.ENOBUF are nil. No wonder they are equal.