From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9F0894696C3 for ; Mon, 13 Apr 2020 10:44:25 +0300 (MSK) References: <865fb768-3c90-ec8e-96cf-7d7598a9f6e0@tarantool.org> <711c06ec-7953-fcb0-f0cd-a1b68a37e8ae@tarantool.org> From: lvasiliev Message-ID: Date: Mon, 13 Apr 2020 10:44:24 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Tarantool-patches] [PATCH v3 0/2] Adapt luarocks for tarantoolctl List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yaroslav Dynnikov Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy Hi. Thanks you for the feedback! On 12.04.2020 21:30, Yaroslav Dynnikov wrote: > Hi, guys. > > Recently we talked to Leonid in chat and discussed the necessity of > removing flags. I've offered Leonid to check behavior, so here is what > I've found. > > My point of view (now and then) is that they're neither useful nor > harmful. Earlier I did agree to blacklist them, but looking at Leonids > patch set this week I've changed my mind as the second commit seems > just worthless to me. > > Inline help says: > > ``` > --lua-dir=     Which Lua installation to use. > --lua-version=    Which Lua version to use. > --global               Use the system tree when `local_by_default` is > `true`. > --local                Use the tree in the user's home directory. >                        To enable it, see > '/opt/tarantool-install/bin/tarantoolctl help path'. > > Rocks trees in use: >         /tmp/tmp.JY1fgy8La9/.rocks ("user") >         /opt/tarantool-install ("system") > ``` > > * Tarantool does define `LOCAL_BY_DEFAULT = true`, >   (i.e. `--local` is our default behavior) > > * "System tree" is the place where tarantool is installed >   (`-DCMAKE_INSTALL_PREFIX`). > > * "Home directory" in tarantool is overriden with `./.rocks`. > > * See "rocks: update luarocks to 3.1.1" 4222c1f6 > . > > * Both `--local` and `--global` are only shortcuts for predefined >   `--tree=`, which isn't going to be removed. > > * Speaking of `--lua-dir` and `--lua-version`, they look to be neither >   useful nor harmful. > Do I understand correctly that you propose to discard the commit with deleting flags? > Please, notice that command-line help refers to `tarantoolctl help > path`, but > > 1. It should be `tarantoolctl rocks help` (I guess there are many of >    such places) It was commented by Vlad > 2. `rocks path` command is disabled in your patch. > Rocks path was disabled before my patch and it wasn't at the list (list from ticket https://github.com/tarantool/tarantool/issues/4629) of desired commands to include. Do you propose to add the "path" command? > I'm a lazy developer and I don't like unnecessary restrictions. If I > were you, I'd drop the second commit ("Delete flags which can't be used > with tarantoolctl rocks" 1b51b2f) and enable back `rocks path` command. > Let people decide whether they need it or not. > > Finally, a few words about documentation. I've tried to write down all > supported commands and flags, and I found it's really difficult and > verbose. I'm withdrawing my suggestion to clarify it, I don't know what > to do. Perhaps, documentation should just refer to inline help, as it's the > only up-to-date information, and still correct enough. > Ok > Дынников Ярослав.