From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 632066EC55; Fri, 9 Jul 2021 12:43:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 632066EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625823790; bh=N02Bt3S3YEBRMEhh4Aprep5dlL7QGhjk+o6MqYYaFeM=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=bFlnvJPoC3nu4qaYSpPgEzHeBp8Vu2HFpUEY2w48dy3VnQCDMIDwbsINDdG9MH9Ry vsCcsLCrAB7QQ2DZqNcc4DI5H7F4q+i28ZTuqIY2/wAOOiTLlNTd1rEWT3TLyRrkGi TfJDatc5lbHVXpHAeXyGTFbXNR56ZsVfonEpuHgQ= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 113746EC55 for ; Fri, 9 Jul 2021 12:43:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 113746EC55 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1m1n2K-0006jx-EK; Fri, 09 Jul 2021 12:43:08 +0300 To: Vladislav Shpilevoy , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: <099ee3af81a4d9c9b9dece44f5d75d0c4351c91c.1624918077.git.sergepetrenko@tarantool.org> Message-ID: Date: Fri, 9 Jul 2021 12:43:08 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB703477AD6D36A6E3BF61D829C414636D182A05F53808504023EB81808DB816F096A11697A020F0FE46CF037865D85220B5125A8715C4ACF0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922E451CE6E839B1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063786F1F539FBE87B778638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83B1F5BE97577DC2D382EDEE71405EF23117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE41BF15D38FB6CB3A040F9FF01DFDA4A84AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C30942DC5495D0595E76E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C2C2559B29ED8195043847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5D26E61FE6E111290D4E261E8001CEF00E54BC078A7BC5E95D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753753CEE10E4ED4A7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D1F112031EF3D62B3347EB3ADA44A57BE592C326438085FE9C5E76FF9CED98CF22B12371FC1A3611D7E09C32AA3244CB9FC284A1CFBF5356C8F958A7CC3A0EE55E75C8D0ED9F6EEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojR+u4utVEKRyFbJIE4V5okg== X-Mailru-Sender: 583F1D7ACE8F49BDCE9F948DA3B7A953EA125DD3F35CB291FAADC9879D578B55B74BA1A0E3C6524A6BB2E709EA627F343C7DDD459B58856F0E45BC603594F5A135B915D4279FF0579437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 01/12] replication: always send raft state to subscribers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 04.07.2021 15:12, Vladislav Shpilevoy пишет: > Hi! Thanks for the patch! > > On 29.06.2021 00:12, Serge Petrenko via Tarantool-patches wrote: >> Tarantool used to send out raft state on subscribe only when raft was >> enabled. This was a safeguard against partially-upgraded clusters, where >> some nodes had no clue about Raft messages and couldn't handle them >> properly. >> >> Actually, Raft state should be sent out always. For example, promote >> will be changed to bump Raft term even when Raft is disabled, and it's >> important that everyone in cluster has the same term for the sake of promote >> at least. >> >> So, send out Raft state to every subscriber with version >= 2.6.0 >> (that's when Raft was introduced). >> Do the same for Raft broadcasts. They should be sent only to replicas >> with version >= 2.6.0 >> >> Closes #5438 >> --- >> src/box/box.cc | 11 ++-- >> src/box/relay.cc | 4 +- >> test/replication/gh-5438-raft-state.result | 63 ++++++++++++++++++++ >> test/replication/gh-5438-raft-state.test.lua | 28 +++++++++ > I propose to rename raft -> election in the test name. To be > consistent with the existing election tests. Also it simplifies > running all of them by doing `python test-run.py election`. Thanks for the review! Sure, fixed. -- Serge Petrenko