From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6B3C06EC58; Thu, 5 Aug 2021 01:27:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6B3C06EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628116043; bh=PWHF40AGEq4JcTAmIiA0B0RxHTh/QWFK6wyQJf4Fvgw=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=HvwNSFYHA5tlnKvDwk0OmXOKFlN+QKRND7vKipG7FLTO+U0aT8CazCjwIYVAXES0B 9EwAl/1mTR3v6siPDRho8+mqlq3iA4YUbfUByACdp2dDq8r5UiDERIGydCAeES/5nw N8Kg/i84VJMHmEJfcjNXo/l35XfJhjl/UVmO7hwk= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A15DB6EC58 for ; Thu, 5 Aug 2021 01:27:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A15DB6EC58 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mBPM9-00076T-2h; Thu, 05 Aug 2021 01:27:21 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: Date: Thu, 5 Aug 2021 00:27:20 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B2770D7874BA03B4AE182A05F538085040F8D1EF2AE360ADF2ED0F166D4FF2AF89CAA18FF203C0AC4041249BE5FC282CF6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B84F9009663064BD8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E83A75776AE7739243C71B31AA31E73D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50555CCE3650072E84779C55DD6CCA3363C X-C1DE0DAB: 0D63561A33F958A542ED213DF711B87A21A36F7F1A8E3751CCCF2C129A42529BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FDC9529E4578B99C0E2DBBB6AE29342E345FBAF027AEAFACDE86FC46457335441A9FA2A3892A7ED31D7E09C32AA3244CA95CABBF35E7FB9D74DD90B9552BC1EEC86C126E7119A0FE729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3XR5kAUsbdlaA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D17DFBACAE1EF1BC75019B80BDD3EA4183841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 5/7] sql: remove implicit cast from OP_MakeRecord X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 28.07.2021 22:51, imeevma@tarantool.org wrote: > This patch removes deprecated implicit cast from OP_MakeRecord opcode. > Not there will be no implicit cast in OP_MakeRecord opcode. 1. Not -> Note? The commit seems strange. You basically said the same thing 3 times: 1 in th title and 2 in the message. > diff --git a/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md b/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md > new file mode 100644 > index 000000000..9f523d3ed > --- /dev/null > +++ b/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md > @@ -0,0 +1,3 @@ > +## feature/sql > + > +* Implicit cast for comparison now works according to defined rules (gh-4230). 2. Please, try to be more specific here. Users won't understand anything from this sentence.