From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0B2A0469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  2 Mar 2020 11:10:49 +0300 (MSK)
References: <b6cf85b5ac4fa1d4e76ceaa89c9e74517e75137e.1582674708.git.v.shpilevoy@tarantool.org>
 <08e87903-c00a-9f8a-ff25-5199eb6be0f8@tarantool.org>
 <98c0554d-be84-578c-f8e9-d64b23d63623@tarantool.org>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <ddd8aa66-b376-034c-fa0b-d4db26e6be61@tarantool.org>
Date: Mon, 2 Mar 2020 11:10:48 +0300
MIME-Version: 1.0
In-Reply-To: <98c0554d-be84-578c-f8e9-d64b23d63623@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] router:
 bucket_id_strcrc32 and bucket_id_mpcrc32
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Your tests fail on Tarantool 1.10:

[001] Test failed! Result content mismatch:
[001] --- unit/router.result	Mon Mar  2 10:54:48 2020
[001] +++ unit/router.reject	Mon Mar  2 11:02:21 2020
[001] @@ -75,7 +75,7 @@
[001]   |   - - string
[001]   |     - '1'
[001]   |     - 477
[001] - |   - - ctype<struct 106>
[001] + |   - - number
[001]   |     - 1
[001]   |     - 477
[001]   | ...


Without taking this into account - patch LGTM.


On 29/02/2020 20:09, Vladislav Shpilevoy wrote:
> The aforementioned module won't print a warning only once. It will
> print all the errors again once a code reload happens, because
> 'local errors_issued = {}' will be called again on reload, and
> will clear 'errors_issued' table. But perhaps it was done
> intentionally.
> 
> I made it the same way. Intentionally. In that case it will help
> user to replace all bucket_id() calls during reloads, and after each
> reload he will be able to validate whether the message is printed
> again anywhere.

I see nothing bad to print deprecation message after code reload again. 
It doesn't lead to flood into logs as it's a manual action.

---
Oleg Babin