From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 426326EC5D; Mon, 5 Apr 2021 17:05:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 426326EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617631542; bh=LRCZUzjJCkgA68Y+oDA41vEaMXkxP5AIcF4mBZUmjbg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gLG+A9+pyMNwQdToWwo2mXPQy8O8LI7tYxIeXWx4HJPQc8P8pj5nC4EG6snBnm//y gSDYiWkWIXfTkRv6BJBPubrTdHIW8L49NU/5YmdWDwV8qdhFjvsrweWrvyIZ9+FRWO ZzAUVE2CxQhlLUEoCwsPGIkLXRFX8M33R3DmTCqA= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 106076EC5D for ; Mon, 5 Apr 2021 17:05:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 106076EC5D Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1lTPrH-00048v-B6; Mon, 05 Apr 2021 17:05:39 +0300 To: Vladislav Shpilevoy , alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <53f906760f240ea0f381fd693000139e8d5e5c8c.1617375300.git.sergepetrenko@tarantool.org> Message-ID: Date: Mon, 5 Apr 2021 17:05:38 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709498CFB6209D8582A182A05F53808504084F5DBBB03AF20514FD068B7450E6E2ECAA1818495E284A9EA2EE13691465158 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE760302A529BCAAAFCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779089FB2CE4EA2908638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C16EE06F5A270FE6AB1250F6F94AD36A208B0D4ABFBA24B71A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE73AFA331E307B52169FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C33B72D73EA5828B68117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF4E3AF26A5AE703EE76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BA889A2BA78D995533AA81AA40904B5D9DBF02ECDB25306B2201CA6A4E26CD07C3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE493D58E677C372A3F47A91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A52FDB9FAD89B4CE41141906CB29499DB512C3D1797CD3A900D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344888A9AABCDD32257D0BDCC50277FA08644F4B94A0D82283C87EFC192177E29D2B795A2B676D50741D7E09C32AA3244C132332413ED596C08C548D0598295DE6CE0B41342B755BCDFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojM00ve/f+0oknTohOkQWRNg== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F8D05178211529EEB5C61F36879AA93E3EB66C3D5EA88D6515424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/4] feedback_daemon: send feedback on server start X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 05.04.2021 16:18, Vladislav Shpilevoy пишет: > Hi! Thanks for the patch! > > On 02.04.2021 16:58, Serge Petrenko wrote: >> Send the first report as soon as instance's initial configuration >> finishes. >> >> Closes #5750 >> --- >> diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua >> index d00eedf39..2ce768642 100644 >> --- a/src/box/lua/feedback_daemon.lua >> +++ b/src/box/lua/feedback_daemon.lua >> @@ -345,7 +345,7 @@ local function guard_loop(self) >> while true do >> >> if get_fiber_id(self.fiber) == 0 then >> - self.fiber = fiber.create(feedback_loop, self) >> + self.fiber = fiber.new(feedback_loop, self) > Why? With fiber.create() feedback daemon proceeds to sending the "initial report" even before lua's box.cfg() exits. This shouldn't break anything, as far as I understand, but `tarantoolctl.test.lua` failed on my machine without this change. -- Serge Petrenko