From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C980543D67A
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 18 Oct 2019 00:13:16 +0300 (MSK)
References: <6de1f18613e9b6a3f716c60b9c85457d2bd9eb64.1571341771.git.v.shpilevoy@tarantool.org>
 <20191017200042.GC9698@uranus.lan>
 <b21e39e6-ec60-9e75-fbf6-857623284663@tarantool.org>
 <20191017210505.GD9698@uranus.lan> <20191017210820.GE9698@uranus.lan>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <dd593ce6-9a2d-0415-ddf3-55c7a2ba6b75@tarantool.org>
Date: Thu, 17 Oct 2019 23:18:22 +0200
MIME-Version: 1.0
In-Reply-To: <20191017210820.GE9698@uranus.lan>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1]
 console: fix usage of an undeclared variable
List-Id: Tarantool development <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org



On 17/10/2019 23:08, Cyrill Gorcunov wrote:
> On Fri, Oct 18, 2019 at 12:05:05AM +0300, Cyrill Gorcunov wrote:
>> On Thu, Oct 17, 2019 at 10:31:00PM +0200, Vladislav Shpilevoy wrote:
>>>>
>>>> We're reading from a socket and there could be EOF, which will
>>>> give us zero return code. But now we will start to yielding
>>>> an error in this case.
>>>>
>>>
>>> set_error is aware of that. It says 'Peer closed' on EOF.
>>
>> Looks reasonable enough. Thanks!
> 
> Still (if only I'm not missing something obvious) this changes
> api a bit -- previously we've been returning empty string for
> this case but now we will print 'Peer closed', hopefully this
> won't be a problem though.
> 
> 	Cyrill
> 

Previously there was an error about undeclared variable.

    'return rc'

Here 'rc' was not declared.