From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 705EC42F4AD
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 16 Jun 2020 01:19:38 +0300 (MSK)
References: <cover.1592151487.git.v.shpilevoy@tarantool.org>
 <c84614d839fe354963bbf11c2e6c83a5093f8e17.1592151487.git.v.shpilevoy@tarantool.org>
 <157801d6432b$5f77cdb0$1e676910$@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <dcc4844d-f9f7-8d74-d582-82c5ba006e54@tarantool.org>
Date: Tue, 16 Jun 2020 00:19:36 +0200
MIME-Version: 1.0
In-Reply-To: <157801d6432b$5f77cdb0$1e676910$@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/2] cmake: split UB sanitations
	into separate flags.
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Timur Safin <tsafin@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the review!

> : diff --git a/cmake/compiler.cmake b/cmake/compiler.cmake
> : index 6c0fa635c..6de8219a0 100644
> : --- a/cmake/compiler.cmake
> : +++ b/cmake/compiler.cmake
> : @@ -269,19 +269,55 @@ macro(enable_tnt_compile_flags)
> :          if (NOT CMAKE_COMPILER_IS_CLANG)
> :              message(FATAL_ERROR "Undefined behaviour sanitizer only
> : available for clang")
> :          else()
> : -            set(SANITIZE_FLAGS "-fsanitize=undefined -fno-sanitize-
> : recover=undefined")
> : +            string(JOIN "," SANITIZE_FLAGS
> : +                "alignment"
> : +                "bool"
> : +                "bounds"
> : +                "builtin"
> : +                "enum"
> : +                "float-cast-overflow"
> : +                "float-divide-by-zero"
> : +                "function"
> : +                "integer-divide-by-zero"
> : +                "return"
> : +                "shift"
> : +                "unreachable"
> : +                "vla-bound"
> : +            )
> : +
> 
> You know, every time I see (unnecessary) quoted strings inside of cmake 
> lists I want to run and fix it immediately. Because there is no actual
> need to quote them - in cmake almost everything is string literal at the end
> 
> Thus I tried to make this construction compacter and less verbose, e.g.

I didn't know the quotes are not needed. Nice! Applied your diff.