From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 354EA27484 for ; Fri, 13 Jul 2018 12:05:29 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gPK0IxdeXu5S for ; Fri, 13 Jul 2018 12:05:29 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E854E2745C for ; Fri, 13 Jul 2018 12:05:28 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: fixed possible leak in sqlite3EndTable References: <08d51d31-a944-e308-c1c2-bf823581607e@tarantool.org> From: Kirill Shcherbatov Message-ID: Date: Fri, 13 Jul 2018 19:05:26 +0300 MIME-Version: 1.0 In-Reply-To: <08d51d31-a944-e308-c1c2-bf823581607e@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Vladislav Shpilevoy > Thanks for the patch! See 1 comment below. > I see two returns below this line. Why have not you replaced > them with goto cleanup? It is not important after space_def_rebuild. But I re factored code with goto cleanup to be consistent.