From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH 3/3] salad: fix heap reserve() behaviour References: <20190222183154.GC1691@chai> From: Vladislav Shpilevoy Message-ID: Date: Fri, 22 Feb 2019 21:38:46 +0300 MIME-Version: 1.0 In-Reply-To: <20190222183154.GC1691@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Konstantin Osipov Cc: vdavydov.dev@gmail.com List-ID: On 22/02/2019 21:31, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/02/22 14:39]: >> Reserve() function by definition should ensure that there is >> enough space to store something. But heap reserve() always just >> increases the capacity twice. Even if there was already enough >> memory. Check for not necessary realloc was done out of this >> function. This was wrong. The commit makes reserve() be real >> reserve(). >> > > OK to push. > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov > Pushed to 2.1.