From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1BC7226391
	for <tarantool-patches@freelists.org>; Tue, 19 Jun 2018 10:59:42 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id eyJ79dG_eN38 for <tarantool-patches@freelists.org>;
	Tue, 19 Jun 2018 10:59:42 -0400 (EDT)
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CBF1F2632E
	for <tarantool-patches@freelists.org>; Tue, 19 Jun 2018 10:59:41 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v2] sql: fix decode analyze sample
References: <20180601165014.30131-1-avkhatskevich@tarantool.org>
 <B58CD8AC-D411-48A7-BCA2-61BB5A18B54D@tarantool.org>
 <82a5964f-ccf6-1d29-78e0-186fa1ebcac0@tarantool.org>
 <B3ED2159-1411-462D-A71F-A208BEED6148@tarantool.org>
From: Alex Khatskevich <avkhatskevich@tarantool.org>
Message-ID: <dc669e36-b9e4-7ed8-89ae-68d3944e3fc8@tarantool.org>
Date: Tue, 19 Jun 2018 17:59:38 +0300
MIME-Version: 1.0
In-Reply-To: <B3ED2159-1411-462D-A71F-A208BEED6148@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org


> As far as I understand, there is only one call of sql_stat4_column().
> You may make this function static and move to where.c,
> if you want so.
Ok.
Let it be here by now.
> +    /* Typecast byte array. */
> I guess, it is obsolete comment.
Deleted
>> +    int col_cnt = mp_decode_array(&a);
> mp_decode_array returns uint32_t, so lets use this type.
Fixed
>> +        if (mem == NULL) {
>> +            diag_set(OutOfMemory, sizeof(Mem), "sqlite3ValueNew”,
> sizeof(struct Mem) or *mem
Fixed
> The rest seems OK to me.