From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DA2A0D56CE3; Tue, 20 Aug 2024 11:57:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DA2A0D56CE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724144236; bh=Ne27bN9doPmUSBN61JYo+14YB6tDSRSFPzTWk8JUu3U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=yzxiugxe6tgUnE21L4oZ8fjjYPuDzyvUzIhdr/ZMHvLqPijSaVQFRfdt5++Lga6iV dWoH0PaD6I/iEEuzLhofhlG3lRWt0gIT9LrVbP8IDEgrE+SaLGqvNAvPuoMLuF2Md0 S3GYh4/nqb5Fx2Bf/uBsn2l/jtSDXFP9BuNtOQQo= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D4ED64363FB for ; Tue, 20 Aug 2024 11:57:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D4ED64363FB Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1sgKfx-00000004n4A-0hO3; Tue, 20 Aug 2024 11:57:13 +0300 Content-Type: multipart/alternative; boundary="------------TwB3Z8u6YMWu9jD5F7P5QtRZ" Message-ID: Date: Tue, 20 Aug 2024 11:57:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Maxim Kokryashkin References: <10ed208fcfacfa4c772f1cebe090595af3452ff3.1720182442.git.sergeyb@tarantool.org> <95ce34d1-234c-4e5c-a9a5-a62a5a5633e8@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD910B3876C1812C915C2A2B9151DE519E4DD0AF8AE21C221F4182A05F5380850402E23B47F687608F6D4FF92D56319F197B837AB8DE25335B4CEE60F83B662A37FEA49DAD9745199E0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E25DEE08FA4D750E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87C89DC316FFCFACCE92ED600B643FEB51328138A63E928CFCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637C991F317CB49A26CD81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE70685510C706CDFBEEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5278DA827A17800CE76631511D42670FFE2EB15956EA79C166176DF2183F8FC7C04E672349037D5FA5725E5C173C3A84C37727919777A35F2B35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5791DCCC40FEBE4775002B1117B3ED6964E3A4AA8FCEB928103803A57F48E4E5A823CB91A9FED034534781492E4B8EEADA3FB0D9844EF8EC5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3442AF01057B6BF9972C838EF31360F48C1EC1403932A763D227CF1F8D5AA62D7CFB3E310DE469C4A01D7E09C32AA3244CFE43F1930A84B06DAB70F9BE574AE9C68C52EDE3A1CAB2D9EA455F16B58544A21C197AAF4D2E4732A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojObjYaDouKIxg8RSdfXGRuA== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458717B6EF941EE9C26BC5A20191D90C84FAB0AE208F86E2D891248AAB0B183AFA0645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS: Always generate 64 bit non-FAT Mach-O object files. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org, Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------TwB3Z8u6YMWu9jD5F7P5QtRZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Max thanks for review! On 19.08.2024 12:45, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > > As this thread replies grew way beyond comprehensible limit, I'll refer > to the GitHub commit instead. > >> Sergey Bronnikov: >> * added the description and the trimmed the test for the problem > Typo: s/the trimmed/trimmed/ > > > > Lines: 149-150: >> -- The function builds a Mach-O object file and retrieves its >> -- header fields. > I believe, "validates" fits better than "retrieves" here. > > Line: 153: >> -- LuaJIT always generate 64-bit, non-FAT Mach-O object files. > Typo: s/generate/generates/ Both typos were fixed: --- a/test/tarantool-tests/lj-865-cross-generation-mach-o-file.test.lua +++ b/test/tarantool-tests/lj-865-cross-generation-mach-o-file.test.lua @@ -146,11 +146,11 @@ local function read_mach_o_hdr(buf, hw_arch)    return mach_header  end --- The function builds a Mach-O object file and retrieves its +-- The function builds a Mach-O object file and validates its  -- header fields.  local function build_and_check_mach_o(subtest)    local hw_arch = subtest.name -  -- LuaJIT always generate 64-bit, non-FAT Mach-O object files. +  -- LuaJIT always generates 64-bit, non-FAT Mach-O object files.    assert(hw_arch == 'arm64')    subtest:plan(5) > > Otherwise, LGTM. --------------TwB3Z8u6YMWu9jD5F7P5QtRZ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Max

thanks for review!

On 19.08.2024 12:45, Maxim Kokryashkin wrote:
Hi, Sergey!
Thanks for the patch!

As this thread replies grew way beyond comprehensible limit, I'll refer
to the GitHub commit instead.


Sergey Bronnikov:
* added the description and the trimmed the test for the problem

Typo: s/the trimmed/trimmed/

<lj-865-cross-generation-mach-o-file.test.lua>

Lines: 149-150:

-- The function builds a Mach-O object file and retrieves its
-- header fields.

I believe, "validates" fits better than "retrieves" here.

Line: 153:

-- LuaJIT always generate 64-bit, non-FAT Mach-O object files.

Typo: s/generate/generates/

Both typos were fixed:


--- a/test/tarantool-tests/lj-865-cross-generation-mach-o-file.test.lua
+++ b/test/tarantool-tests/lj-865-cross-generation-mach-o-file.test.lua
@@ -146,11 +146,11 @@ local function read_mach_o_hdr(buf, hw_arch)
   return mach_header
 end
 
--- The function builds a Mach-O object file and retrieves its
+-- The function builds a Mach-O object file and validates its
 -- header fields.
 local function build_and_check_mach_o(subtest)
   local hw_arch = subtest.name
-  -- LuaJIT always generate 64-bit, non-FAT Mach-O object files.
+  -- LuaJIT always generates 64-bit, non-FAT Mach-O object files.
   assert(hw_arch == 'arm64')
 
   subtest:plan(5) 

Otherwise, LGTM.
--------------TwB3Z8u6YMWu9jD5F7P5QtRZ--