Hi, Max

thanks for review!

On 19.08.2024 12:45, Maxim Kokryashkin wrote:

Hi, Sergey!
Thanks for the patch!

As this thread replies grew way beyond comprehensible limit, I'll refer
to the GitHub commit instead.

Sergey Bronnikov:
* added the description and the trimmed the test for the problem

Typo: s/the trimmed/trimmed/

<lj-865-cross-generation-mach-o-file.test.lua>

Lines: 149-150:

-- The function builds a Mach-O object file and retrieves its
-- header fields.

I believe, "validates" fits better than "retrieves" here.

Line: 153:

-- LuaJIT always generate 64-bit, non-FAT Mach-O object files.

Typo: s/generate/generates/

Both typos were fixed:

--- a/test/tarantool-tests/lj-865-cross-generation-mach-o-file.test.lua
+++ b/test/tarantool-tests/lj-865-cross-generation-mach-o-file.test.lua
@@ -146,11 +146,11 @@ local function read_mach_o_hdr(buf, hw_arch)
   return mach_header
end

--- The function builds a Mach-O object file and retrieves its
+-- The function builds a Mach-O object file and validates its
-- header fields.
local function build_and_check_mach_o(subtest)
   local hw_arch = subtest.name
- -- LuaJIT always generate 64-bit, non-FAT Mach-O object files.
+ -- LuaJIT always generates 64-bit, non-FAT Mach-O object files.
   assert(hw_arch == 'arm64')

   subtest:plan(5)


Otherwise, LGTM.