From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F019E6EC55; Thu, 22 Jul 2021 02:25:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F019E6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1626909907; bh=2UtVPJdnRfGzW79pF+n+qC+OGnutwKZUmIn0HmmWQ2o=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MCUUKcurh5Trb9M41TobLwHyp17SUZrdYtFSAukXQiWWOhjilzHfWQ8a5xaSdy9q2 I8zFmb2nETaPwSoP9ZFvi3lK6W3/Uzh4LLCtjreBad9u4RMlagv3Qo1sYfFPMvY5fC JZvRnN8a1ChAj4hxVkHfydCyQzQtjmeWzYtfBNlc= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E58D36EC55 for ; Thu, 22 Jul 2021 02:25:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E58D36EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m6LaG-0003sL-6X; Thu, 22 Jul 2021 02:25:00 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: Message-ID: Date: Thu, 22 Jul 2021 01:24:59 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30A5AB0699C09BB51962E4FF0DD431C8A182A05F53808504051B155FA56808FE8DFD5663A345FBAD3291F683FD6DC6D6B1413E42DA970876A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE755BE8F535441E38CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063702DFA59B3C994360EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F23F146B7DCFD454045506A5F2EA9087C9CC7F00164DA146DAFE8445B8C89999728AA50765F7900637B18CEC08E50EEB57389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC84CB6874B0BCFF0B8F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDCE939D40DBB93CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50539780B9EB20618E9BCF66297ABC45D95 X-C1DE0DAB: 0D63561A33F958A526AB7DFEA6AAA1651B7F5A1496437A0250E38CBC9FC6A13CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3455AC8BF8E3153BA02B949D65023F118488C0858DE20FB82E6931D91A35A53A4A6DF2B0051BC85EAE1D7E09C32AA3244C58EE9B4B95EBE0B732D2AAFA35DF618230452B15D76AEC14FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojaAaPr+N/4d29lEwpi6Zdrw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D7A7DA2DFCF415BC598B0104B1EC37E043841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 07/16] replication: send current Raft term in join response X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/src/box/relay.cc b/src/box/relay.cc > index 4b102a777..70f1a045b 100644 > --- a/src/box/relay.cc > +++ b/src/box/relay.cc > @@ -451,6 +453,10 @@ relay_initial_join(int fd, uint64_t sync, struct vclock *vclock, > row.sync = sync; > coio_write_xrow(&relay->io, &row); > > + xrow_encode_raft(&row, &fiber()->gc, &raft_req); > + row.sync = sync; > + coio_write_xrow(&relay->io, &row); You might need to send it before the limbo checkpoint. Otherwise the problem is exactly the same - the master could send the limbo state, the replica applied it, then the master dies before sending the raft state, then the replica has limbo's term > raft term. I wish we could test it somehow simple.