From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8B67729920
	for <tarantool-patches@freelists.org>; Tue, 28 Aug 2018 20:58:40 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id JlbGPg6dK7k2 for <tarantool-patches@freelists.org>;
	Tue, 28 Aug 2018 20:58:40 -0400 (EDT)
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4D32729870
	for <tarantool-patches@freelists.org>; Tue, 28 Aug 2018 20:58:40 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 1/7] sql: remove struct schema from
 struct Table
References: <cover.1535063199.git.korablev@tarantool.org>
 <e28ee61afcfc2d23262da96978fee5a8f9656be8.1535064700.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <dbf634e1-560f-aa52-16dd-7558f03e7142@tarantool.org>
Date: Tue, 28 Aug 2018 21:58:32 -0300
MIME-Version: 1.0
In-Reply-To: <e28ee61afcfc2d23262da96978fee5a8f9656be8.1535064700.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>

Thanks for the patch!
I have pushed my review fix on the branch. Here
it is:

diff --git a/src/box/sql/expr.c b/src/box/sql/expr.c
index a41ea8f13..7ddedaf8a 100644
--- a/src/box/sql/expr.c
+++ b/src/box/sql/expr.c
@@ -1515,7 +1515,6 @@ sqlite3SrcListDup(sqlite3 * db, SrcList * p, int flags)
  		struct SrcList_item *pNewItem = &pNew->a[i];
  		struct SrcList_item *pOldItem = &p->a[i];
  		Table *pTab;
-		pNewItem->pSchema = pOldItem->pSchema;
  		pNewItem->zName = sqlite3DbStrDup(db, pOldItem->zName);
  		pNewItem->zAlias = sqlite3DbStrDup(db, pOldItem->zAlias);
  		pNewItem->fg = pOldItem->fg;
diff --git a/src/box/sql/sqliteInt.h b/src/box/sql/sqliteInt.h
index 35d3f4cec..6bca506e7 100644
--- a/src/box/sql/sqliteInt.h
+++ b/src/box/sql/sqliteInt.h
@@ -2377,7 +2377,6 @@ struct SrcList {
  	int nSrc;		/* Number of tables or subqueries in the FROM clause */
  	u32 nAlloc;		/* Number of entries allocated in a[] below */
  	struct SrcList_item {
-		Schema *pSchema;	/* Schema to which this item is fixed */
  		char *zName;	/* Name of the table */
  		char *zAlias;	/* The "B" part of a "A AS B" phrase.  zName is the "A" */
  		Table *pTab;	/* An SQL table corresponding to zName */


SrcList_item is actually a table most times, so lets
remove Schema from it as well.