From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 296DB2EC23 for ; Mon, 3 Jun 2019 14:45:08 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 45rI2bGjAQpw for ; Mon, 3 Jun 2019 14:45:08 -0400 (EDT) Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7940A2EB49 for ; Mon, 3 Jun 2019 14:45:07 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 0/2] Add _vcollation and fetch in net.box References: From: Vladislav Shpilevoy Message-ID: Date: Mon, 3 Jun 2019 20:45:03 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Roman Khabibov Please, provide name of the branch, and issue link. There are 2 branches on this issue, and I don't know which one to review. On 30/05/2019 15:36, Roman Khabibov wrote: > As I understood "readable for all" means that filter for > "_vcollation" must always return "true", because the condition > "User has read access to according system space" is always > met. > > Roman Khabibov (2): > schema: add "_vcollation" sysview > net.box: fetch '_vcollation' sysview into the module > > src/box/bootstrap.snap | Bin 4374 -> 4441 bytes > src/box/lua/net_box.lua | 24 ++++++-- > src/box/lua/space.cc | 2 + > src/box/lua/upgrade.lua | 25 ++++++++ > src/box/schema_def.h | 2 + > src/box/sysview.c | 13 ++++ > test/app-tap/tarantoolctl.test.lua | 4 +- > test/box-py/bootstrap.result | 13 +++- > test/box/access_misc.result | 4 ++ > test/box/access_sysview.result | 92 ++++++++++++++++++++++++++--- > test/box/access_sysview.test.lua | 30 ++++++++++ > test/box/alter.result | 6 +- > test/box/net.box.result | 2 +- > test/box/stat_net.result | 4 +- > test/wal_off/alter.result | 2 +- > 15 files changed, 201 insertions(+), 22 deletions(-) >