From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0F9986EC40; Fri, 13 Aug 2021 08:30:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0F9986EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628832624; bh=DLStZ0HU06aqHt8LgQpS5/YqLJsQrpMU+5pXd78ateg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hNKzQaTgXz815oIwWFR982sRSmS/UPfHJjmEQt9TTf0UZk9iNWH+UaXDQNEC0d7t0 ggeV0YZVYitid9JlYejlu0La0+CFSDlpnMD/57IwjuVwFr7aGfosmBebyW679Gd2N0 jr4KX3oPnh+TD+GaNQJ5mbRQHMl3D1b0DFiqvM4Q= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6D7A86EC40 for ; Fri, 13 Aug 2021 08:30:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6D7A86EC40 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1mEPlt-0005RI-9U; Fri, 13 Aug 2021 08:30:21 +0300 To: Serge Petrenko , vdavydov@tarantool.org, sergos@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <3a954f7793e6356cefb8cd0151a6434382ec876c.1628810253.git.sergepetrenko@tarantool.org> Message-ID: Date: Fri, 13 Aug 2021 08:30:20 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <3a954f7793e6356cefb8cd0151a6434382ec876c.1628810253.git.sergepetrenko@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9ECFD080E047A606F56291F8739A291D6182A05F538085040BEE04C754E86990FE10B7D6015F8D79CC4DB0C854623EB43EBC38DBFAC11A365 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922D113DFDC6D5A3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371D26D2A8652661258638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BACEC91D51B6A4431989EDC1810563FE117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4BA7B8E9D6D956BB52D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3A7DFDF579AB090EF040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006379FC65886B7F75608EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505D32135C74DF215E62BE95023727C2852 X-C1DE0DAB: 0D63561A33F958A5EE7717474C3CFA1878C40B464EFF07ECD9AD8819243211D9D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA750E14360347543F58410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AF12ADB97C97CD89801C41B1F797BC2CBD53906F032CF59BC78DEE5C9DFDF9F3DF768EFF0102C5AE1D7E09C32AA3244C0505AB436C5BF669E9B95D360083B24F408A6A02710B7304927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0dLV0c3jbkxmrM7lepkNsA== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6B56A769F0C3A964BCE10B7D6015F8D79CB67A942A63B4089A7019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD287402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 1/2] lua: introduce table.equals method X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your patch. It seems it works in quite strange way: ``` tarantool> table.equals({a = box.NULL}, {}) --- - true ... tarantool> table.equals({}, {a = box.NULL}) --- - false ... ``` I can change arguments order to get different result. Expected false in both cases. For tap it was considered as buggy behaviour https://github.com/tarantool/tarantool/issues/4125 On 13.08.2021 02:30, Serge Petrenko via Tarantool-patches wrote: > Introduce table.equals for comparing tables. > The method respects __eq metamethod, if provided. > > Needed-for #5894 > --- >