From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AE0F7469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat,  3 Oct 2020 01:08:45 +0300 (MSK)
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-7-roman.habibov@tarantool.org>
 <20200916201823.GE10599@tarantool.org>
 <4b304f32-379a-fb50-f427-615a91646b7d@tarantool.org>
 <20200918125901.GL10599@tarantool.org>
 <9C52EA98-F9AD-44A5-8755-E2A76372964E@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <db246d15-f89e-afdd-a2c0-f38e23a04a25@tarantool.org>
Date: Sat, 3 Oct 2020 00:08:43 +0200
MIME-Version: 1.0
In-Reply-To: <9C52EA98-F9AD-44A5-8755-E2A76372964E@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH v4 6/6] sql: support column addition
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>, Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the fixes!

>>>> In Postgres for instance, one can add column for non-empty table and
>>>> it is considered to be ok (new column is filled with default value).
>>>> We can use ephemeral tables as temporary holder while rebuilding space.
>>>
>>> Ephemeral spaces can't be used at least because of vinyl, because may
>>> not fit into the memory.
>>
>> Anyway they are used for vinyl even now.
>>
>>> With Roman we decided to implement non-empty
>>> alter later as a separate issue.
>>
>> Ok, then please create follow-up issue with proposed approach.
> We may patch the box code and implement DEFAULT (and NULL ?)inside
> box. This trigger will update space’s tuples during <ALTER TABLE ADD COLUMN>.
> In any case, we need to patch box. We will do it later.

I don't think Nikita meant that you need to implement it now. He
said you need to ensure the task is not lost. So you either need
to find an existing issue about this, or create a new issue.