From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8FB54469719 for ; Thu, 1 Oct 2020 01:00:52 +0300 (MSK) References: <12d3cc3577e45946a82c8d23b69508a4c5653346.1600862684.git.imun@tarantool.org> <9f25b850-0c4e-f3c4-7762-22065ebfbc48@tarantool.org> <20200930093004.GB18920@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Thu, 1 Oct 2020 00:00:51 +0200 MIME-Version: 1.0 In-Reply-To: <20200930093004.GB18920@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback for fibers switch-over List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Thanks for the fix attempt! >> To make lib/core more self-sufficient we could make cord_on_yield >> inlined in fiber.h under a macros like LIBCORE_USE_DEFAULT_ON_YIELD. >> Which would be set by default to 1, but to 0 in the executable file. > > Oh, this is a nice one. It might be a solution but... > >> >> Could help not to change the test binaries, and whatever else depends >> on lib/core, but does not care about Lua. > > ...unfortunately it's not. At first, we need to build both libraries > with the new define set to 1 and to 0. Furthermore, this leads to link > all tests against "coretest" instead of original "core". However, tests > implicitly dependent on "core" are still linked against it, so the issue > is not solved. > >> >> I do not insist, but I will do that myself if someday I will need to >> write a new unit test (raft, for example). > > I would be glad to fix the issue, so let's return to it a bit later. > I hope there is a CMake recipe or hack for this case. Ok, then up to you what to do with it. I can't think of a simpler solution for now, and I am ok with the current one.