From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AE9C6322B8 for ; Thu, 27 Jun 2019 15:01:52 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pU98zshLbHJ6 for ; Thu, 27 Jun 2019 15:01:52 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DCB823224D for ; Thu, 27 Jun 2019 15:01:51 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 0/2] sql: boolean introduction follow-ups References: From: Vladislav Shpilevoy Message-ID: Date: Thu, 27 Jun 2019 21:02:40 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Nikita Pettik , Kirill Yukhin Hi! Thanks for the patchset! LGTM. On 25/06/2019 13:42, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/tree/np/boolean-follow-ups > > First patch gets rid of redundant conversion of results from booleans > to numeric values 0 and 1 in testing framework (sqltester). > > Second one fixes obvious bug during comparison of booleans with values > of other types. > > Nikita Pettik (2): > sqltester: don't convert booleans to 0/1 numerics > sql: fix antisymmetric boolean comparison in VDBE > > src/box/sql/vdbeaux.c | 2 + > test/sql-tap/atof1.test.lua | 2 +- > test/sql-tap/autoinc.test.lua | 2 +- > test/sql-tap/cse.test.lua | 10 +- > test/sql-tap/e_select1.test.lua | 8 +- > test/sql-tap/func.test.lua | 42 +++--- > test/sql-tap/func5.test.lua | 30 ++++- > .../gh-3251-string-pattern-comparison.test.lua | 18 +-- > test/sql-tap/in1.test.lua | 26 ++-- > test/sql-tap/in2.test.lua | 2 +- > test/sql-tap/in3.test.lua | 16 +-- > test/sql-tap/in4.test.lua | 2 +- > test/sql-tap/insert1.test.lua | 4 +- > test/sql-tap/lua/sqltester.lua | 24 ---- > test/sql-tap/lua_sql.test.lua | 2 +- > test/sql-tap/misc1.test.lua | 6 +- > test/sql-tap/select1.test.lua | 2 +- > test/sql-tap/select7.test.lua | 4 +- > test/sql-tap/selectG.test.lua | 2 +- > test/sql-tap/sql-errors.test.lua | 4 +- > test/sql-tap/subquery.test.lua | 6 +- > test/sql-tap/subselect.test.lua | 4 +- > test/sql-tap/tkt-80e031a00f.test.lua | 148 ++++++++++----------- > test/sql-tap/tkt-a7b7803e.test.lua | 16 +-- > test/sql-tap/tkt-b351d95f9.test.lua | 2 +- > test/sql-tap/tkt1473.test.lua | 30 ++--- > test/sql-tap/tkt3346.test.lua | 2 +- > test/sql-tap/tkt3493.test.lua | 28 ++-- > test/sql-tap/triggerC.test.lua | 2 +- > test/sql-tap/types.test.lua | 2 +- > test/sql-tap/where5.test.lua | 4 +- > test/sql-tap/whereB.test.lua | 102 +++++++------- > test/sql-tap/with2.test.lua | 6 +- > 33 files changed, 283 insertions(+), 277 deletions(-) >