From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2E2D5445320
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 13 Jul 2020 16:36:57 +0300 (MSK)
References: <1594199230-26036-1-git-send-email-alyapunov@tarantool.org>
 <1594199230-26036-2-git-send-email-alyapunov@tarantool.org>
 <4107c5fb-11af-16df-26e2-2c134dc0a46b@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <d9ad1b43-c2f8-74fe-c4d7-34a9e6f25c1c@tarantool.org>
Date: Mon, 13 Jul 2020 16:36:56 +0300
MIME-Version: 1.0
In-Reply-To: <4107c5fb-11af-16df-26e2-2c134dc0a46b@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 1/2] alter: use good c++ style
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the review! all good except one more question below?

On 11.07.2020 22:53, Vladislav Shpilevoy wrote:
>
>>   void
>> -UpdateSchemaVersion::alter(struct alter_space *alter)
>> +UpdateSchemaVersion::alter(struct alter_space *alter) noexcept
>>   {
>> -    (void)alter;
>> -    ++schema_version;
>> +	(void) alter;
>> +	++schema_version;
> 3. This change seems not to be related.
What are you suggesting to do with it? create separate commit? or don't 
touch it? I hope I haven't to have an gh issue for that.