From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 52AE223834 for ; Fri, 4 May 2018 08:05:15 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OQJQMdvVXX7q for ; Fri, 4 May 2018 08:05:15 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 13F29236CC for ; Fri, 4 May 2018 08:05:14 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 2/5] Move struct on_access_denied_ctx into error.h References: <974e5a841431ec8b25124030c3ce4a9113279d10.1524955403.git.v.shpilevoy@tarantool.org> <20180504110620.mydvpvn35qso2wfu@tkn_work_nb> From: Vladislav Shpilevoy Message-ID: Date: Fri, 4 May 2018 15:05:11 +0300 MIME-Version: 1.0 In-Reply-To: <20180504110620.mydvpvn35qso2wfu@tkn_work_nb> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Alexander Turenko Cc: tarantool-patches@freelists.org Hello. Thanks for review! On 04/05/2018 14:06, Alexander Turenko wrote: > Hi, Vlad! > > One tiny comment here. > > WBR, Alexander Turenko. > > On Sun, Apr 29, 2018 at 01:45:10AM +0300, Vladislav Shpilevoy wrote: >> The issue #3290 was not only about upper/lower Lua functions, but >> about unicode comparison functions too. Actually, the issue >> requests upper/lower exactly to do string comparison, that can be >> done more quick with no garbage strings creation. For this >> Tarantool collations can be used. >> >> To be able to expose collations into Lua, the coll.h/.c, >> coll_def.h/.c and coll_cache.h/.c must be moved from 'box' static >> library into 'core' static library so that they will be built >> together with string utils. But they require 'stat' and >> 'box_error' libraries. The patch prepares the files going to be >> moved, so in the next patch they are just moved, with no changes. >> It saves commit history. > > 'together with string utils' -- no more relevant to the patchset part > above this commit? > Fixed. "together with common utils"