From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 304796F154; Mon, 15 Aug 2022 15:13:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 304796F154 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1660565638; bh=I9acKzizm2fzgFapQfbGqImv8zpX3Xn1NZYR+E5nVS0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ZbxknXMtSd5636mCdyLqI0tqJtpcxcCJbnQtnH6SkfxoqNoQtn5+Ir0qUlNG3nYB2 mEbqV4gaJQmfudOkZ7zWVjU5Bfv88Xu6zeKXjEvTdsxpuxW3MjAYvSYGUEomzeohVY OmPSKvrOFHy+l+th4IIGXQ5/JuWdsV7UpTapp984= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6776B6F154 for ; Mon, 15 Aug 2022 15:13:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6776B6F154 Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1oNYyh-0004J7-Jh; Mon, 15 Aug 2022 15:13:56 +0300 Message-ID: Date: Mon, 15 Aug 2022 15:13:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Igor Munkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <9d4258549598fa5c11a4da1a40ca50cbb6281a16.1660216002.git.imun@tarantool.org> In-Reply-To: <9d4258549598fa5c11a4da1a40ca50cbb6281a16.1660216002.git.imun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD999D8F08CF16C6CA78D09263051051FAE9D7E868F1A8F721C00894C459B0CD1B98C805E47566641514A3B42DE4FE31BC769C2C31D955D3D9595102AAA86CA9C0B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F8E53417176C7207EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AD4B8DECD34330378638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A0FB469B733CADBB245B0AB63A96F884117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC6FC43C45D3E35E8FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209ECD01F8117BC8BEA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCC13F6161A30AABF43AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F7900637A324BD6026912428D81D268191BDAD3D698AB9A7B718F8C4D1B931868CE1C5781A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E6252262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0D4C601CEA03E70EE627B9FD0EE8BFE98817E2EB987470080AF6F70CEAC664D199C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346840168BCAD8054EF7FC475BD553DB0D9A9B8A9CD039D5FF1D91B2181A3B44631DC344316011FC721D7E09C32AA3244C947D2CD0D616DBF2E94BFA4FAC4E7C48C86C126E7119A0FEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojKOC4OzB6pCP7R7Ln4wmzBg== X-Mailru-Sender: 11C2EC085EDE56FAC71737E9F694C0DE7FAB103216CF0B6430CA62D19D9734EBCCF177B771F28C1F645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, please see my comment below. On 11.08.2022 14:17, Igor Munkin wrote: > Use out of source build configuration for LuaJIT testing jobs in all > GitHub workflows. For this build type configuration unique subdirectory > (using GitHub run ID) within runner temporary directory is used as a > binary artefacts tree. > > Signed-off-by: Igor Munkin > --- > .github/actions/environment/action.yml | 5 +++++ > .github/workflows/lint.yml | 3 ++- > .github/workflows/linux-aarch64.yml | 6 +++++- > .github/workflows/linux-x86_64-ninja.yml | 6 +++++- > .github/workflows/linux-x86_64.yml | 7 ++++++- > .github/workflows/macos-m1.yml | 6 +++++- > .github/workflows/macos-x86_64.yml | 7 ++++++- > 7 files changed, 34 insertions(+), 6 deletions(-) > > diff --git a/.github/actions/environment/action.yml b/.github/actions/environment/action.yml > index 43323bc7..7fb2625f 100644 > --- a/.github/actions/environment/action.yml > +++ b/.github/actions/environment/action.yml > @@ -11,3 +11,8 @@ runs: > NPROC=$(sysctl -n hw.logicalcpu 2>/dev/null || nproc) > echo CMAKE_BUILD_PARALLEL_LEVEL=$(($NPROC + 1)) | tee -a $GITHUB_ENV > shell: bash > + - run: | > + # Set BUILDDIR environment variable to specify LuaJIT > + # build directory. > + echo "BUILDDIR=${{ runner.temp }}/build-${{ github.run_id }}" | tee -a $GITHUB_ENV > + shell: bash > diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml > index 28dc6be6..64e8f992 100644 > --- a/.github/workflows/lint.yml > +++ b/.github/workflows/lint.yml > @@ -45,6 +45,7 @@ jobs: > sudo apt -y install cmake make lua5.1 luarocks > sudo luarocks install luacheck > - name: configure > - run: cmake . > + run: cmake -S . -B ${{ env.BUILDDIR }} > - name: test > run: cmake --build . --target LuaJIT-luacheck > + working-directory: ${{ env.BUILDDIR }} > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml > index 8c8dcff1..21d86764 100644 > --- a/.github/workflows/linux-aarch64.yml > +++ b/.github/workflows/linux-aarch64.yml > @@ -53,11 +53,15 @@ jobs: > sudo apt -y update > sudo apt -y install cmake gcc make perl > - name: configure > - run: cmake . ${{ matrix.CMAKEFLAGS }} > + run: > > + cmake -S . -B ${{ env.BUILDDIR }} > + ${{ matrix.CMAKEFLAGS }} > - name: build > run: cmake --build . --parallel > + working-directory: ${{ env.BUILDDIR }} > - name: test > run: cmake --build . --parallel --target test > + working-directory: ${{ env.BUILDDIR }} 1. I don't get an idea to use current dir for CMake and specify a working-directory in a job step. Why not "cmake --build ${{ env.BUILDDIR }}" as above? > > test-tarantool-debug-w-GC64: > name: Tarantool Debug GC64:ON > diff --git a/.github/workflows/linux-x86_64-ninja.yml b/.github/workflows/linux-x86_64-ninja.yml > index 2877d2f6..72d56d54 100644 > --- a/.github/workflows/linux-x86_64-ninja.yml > +++ b/.github/workflows/linux-x86_64-ninja.yml > @@ -44,8 +44,12 @@ jobs: > sudo apt -y update > sudo apt -y install cmake gcc ninja-build perl > - name: configure > - run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja > + run: > > + cmake -S . -B ${{ env.BUILDDIR }} > + -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja > - name: build > run: cmake --build . --parallel > + working-directory: ${{ env.BUILDDIR }} > - name: test > run: cmake --build . --parallel --target test > + working-directory: ${{ env.BUILDDIR }} > diff --git a/.github/workflows/linux-x86_64.yml b/.github/workflows/linux-x86_64.yml > index 44dcce98..4c3ad4c7 100644 > --- a/.github/workflows/linux-x86_64.yml > +++ b/.github/workflows/linux-x86_64.yml > @@ -54,11 +54,16 @@ jobs: > sudo apt -y update > sudo apt -y install cmake gcc make perl > - name: configure > - run: cmake . ${{ matrix.CMAKEFLAGS }} -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }} > + run: > > + cmake -S . -B ${{ env.BUILDDIR }} > + ${{ matrix.CMAKEFLAGS }} > + -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }} > - name: build > run: cmake --build . --parallel > + working-directory: ${{ env.BUILDDIR }} > - name: test > run: cmake --build . --parallel --target test > + working-directory: ${{ env.BUILDDIR }} > > test-tarantool-debug-wo-GC64: > name: Tarantool Debug GC64:OFF > diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml > index e0269d60..e3b6dcda 100644 > --- a/.github/workflows/macos-m1.yml > +++ b/.github/workflows/macos-m1.yml > @@ -68,11 +68,15 @@ jobs: > ${ARCH} brew upgrade cmake gcc make perl > ${ARCH} echo "CMAKE_BUILD_PARALLEL_LEVEL=$(($(sysctl -n hw.logicalcpu) + 1))" >> $GITHUB_ENV > - name: configure > - run: ${ARCH} cmake . ${{ matrix.CMAKEFLAGS }} > + run: > > + ${ARCH} cmake -S . -B ${{ env.BUILDDIR }} > + ${{ matrix.CMAKEFLAGS }} > - name: build > run: ${ARCH} cmake --build . --parallel > + working-directory: ${{ env.BUILDDIR }} > - name: test > run: ${ARCH} cmake --build . --parallel --target test > + working-directory: ${{ env.BUILDDIR }} > > test-tarantool-debug-w-GC64: > name: Tarantool Debug GC64:ON > diff --git a/.github/workflows/macos-x86_64.yml b/.github/workflows/macos-x86_64.yml > index 840806e3..3d2cf581 100644 > --- a/.github/workflows/macos-x86_64.yml > +++ b/.github/workflows/macos-x86_64.yml > @@ -63,11 +63,16 @@ jobs: > brew install --force cmake gcc make perl || > brew upgrade cmake gcc make perl > - name: configure > - run: cmake . ${{ matrix.CMAKEFLAGS }} -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }} > + run: > > + cmake -S . -B ${{ env.BUILDDIR }} > + ${{ matrix.CMAKEFLAGS }} > + -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }} > - name: build > run: cmake --build . --parallel > + working-directory: ${{ env.BUILDDIR }} > - name: test > run: cmake --build . --parallel --target test > + working-directory: ${{ env.BUILDDIR }} > > test-tarantool-debug-wo-GC64: > name: Tarantool Debug GC64:OFF