From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 059F16EC55; Sat, 31 Jul 2021 01:12:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 059F16EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627683175; bh=kUwKlMnFHouiJ6VvgErvOkTkYNqSY3BSF4xrdGOj5zY=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GlUTfvkaPnSyXi6FA/eHhb+Hy7A1sR8xtwWchbsfKBB63H+DsXX1r51oGI55vIAPG QTqm4WTN7wHdCNFy4OseafAP7i1uB4tJp85KEPSqHhQ5o9jN/7WMEoWVLCdQ/Ecn3r 8jQArTOoR8NYq2z0ktl9ffxyDg2bP75sAewRG2Mg= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 06C816EC55 for ; Sat, 31 Jul 2021 01:12:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 06C816EC55 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m9akO-0001ff-6x; Sat, 31 Jul 2021 01:12:52 +0300 To: Vladimir Davydov Cc: tarantool-patches@dev.tarantool.org References: <6c3509125f24f6276be678d6b8f1ac264631d048.1627024646.git.vdavydov@tarantool.org> <20210730084419.vywinihhqdik74mr@esperanza> Message-ID: Date: Sat, 31 Jul 2021 00:12:51 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210730084419.vywinihhqdik74mr@esperanza> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3FDAB68B812060C77E97CF8617D978122182A05F5380850401FB926F1EEA8657D69F4D689BD28B2EBCBD5CCFAABF5768C325908CC3CDECCE0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE745C0EDBD94D46193EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F08BD7C3AB07DC7F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E35A70AE3626BCF54FA16775FA35055E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC5FC25ED3FCEC3375A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505C28EBB49D9AB9E42B319005D0F80A57A X-C1DE0DAB: 0D63561A33F958A57BAC60041B901EF6EEC173D341A1B994344FE3E011773FD5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34ECB3E21D3CD9CB4F3D8C35995CA523F30FAF5D43DB617D3D4A8E8EE921ABA2521AD5AFC37C76A8C31D7E09C32AA3244CB8EC3F48BB68E0862269FE5A90DD26E9F26BFA4C8A6946B8729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojWBddABnKmoLU+wlSvB+GsA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D3B5BF7BFF329BEB3140F5205F9B45A173841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 11/20] net.box: rewrite response decoder in C X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the fixes! > diff --git a/src/box/lua/net_box.c b/src/box/lua/net_box.c > index 2d2562550752..ac9052de286c 100644 > --- a/src/box/lua/net_box.c > +++ b/src/box/lua/net_box.c > @@ -664,7 +664,7 @@ netbox_encode_method(struct lua_State *L) > return 0; > } > > -/** > +/* There is misunderstanding, sorry. As doxygen I meant only these '@a param desc' lines. The /** are a part of our code style, look: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#code-style All out-of-function comments use /** on the first line, all comments inside of functions use /* on the first line. After your fix this - the commit LGTM.