From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E61D642EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 19 Jun 2020 02:13:00 +0300 (MSK)
References: <cover.1591701695.git.sergepetrenko@tarantool.org>
 <e85bfdfa74b7b9f1e6b14625b78833382e97947c.1591701695.git.sergepetrenko@tarantool.org>
From: Leonid Vasiliev <lvasiliev@tarantool.org>
Message-ID: <d9221171-68b7-f39c-02f1-ceac39e19b60@tarantool.org>
Date: Fri, 19 Jun 2020 02:12:59 +0300
MIME-Version: 1.0
In-Reply-To: <e85bfdfa74b7b9f1e6b14625b78833382e97947c.1591701695.git.sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 3/8] txn: add TXN_WAIT_ACK flag
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, v.shpilevoy@tarantool.org, sergos@tarantool.org, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org

Hi! Thank you for the patch.


>   	stailq_foreach_entry(stmt, &txn->stmts, next) {
>   		if (stmt->has_triggers) {
>   			txn_init_triggers(txn);
>   			rlist_splice(&txn->on_commit, &stmt->on_commit);
>   		}
> +		is_sync = is_sync || stmt->space->def->opts.is_sync;

Seems like
"... || (stmt->space != NULL && stmt->space->def->opts.is_sync);"
can be moved here from "replication: make sync transactions wait quorum".

LGTM.