From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A7CEE445320 for ; Mon, 6 Jul 2020 16:29:56 +0300 (MSK) References: <1593757997-4145-1-git-send-email-alyapunov@tarantool.org> From: Aleksandr Lyapunov Message-ID: Date: Mon, 6 Jul 2020 16:29:55 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Tarantool-patches] [PATCH 00/15] Transaction engine for memtx engine List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org Hi, thank for your reply. Sure, I'll try to do it correctly when I send next version, I hope today. On 05.07.2020 20:03, Vladislav Shpilevoy wrote: > Hi! > > Could you please provide branch and issue links, and put the > reviewers in CC/TO? Like described here > https://github.com/tarantool/tarantool/wiki/Code-review-procedure. > > I assume the branch is this: > https://github.com/tarantool/tarantool/tree/alyapunov/gh-4897-memtx-tx-engine-v6 > And the issue is this: > https://github.com/tarantool/tarantool/issues/4897 > > The CI looks very broken: > https://gitlab.com/tarantool/tarantool/-/pipelines/162943109 > I can't build the branch either. > > Besides, I see a dirty commit 'fixme' on the branch. What is it? > >> Work is still in progress but the patchset is ready for discussions. > Would be nice to have some document with general overview of what is > done. Usually this is an RFC. Or at least in the cover letter or in > the commit messages and comments. This feature is definitely not an > easy patch to understand from sources only in a short time.