From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 865D02E131 for ; Sun, 26 May 2019 08:03:37 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r7WIjYU9-9Fg for ; Sun, 26 May 2019 08:03:37 -0400 (EDT) Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 44E302E113 for ; Sun, 26 May 2019 08:03:37 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v4 3/4] box: introduce column_mask for ck constraint From: Vladislav Shpilevoy References: <16fabe763ee57c8cd5c807b24d0fc500ad5a8bae.1558014727.git.kshcherbatov@tarantool.org> <148cfacb-757b-0c4a-7b7d-efaa18c6ffac@tarantool.org> Message-ID: Date: Sun, 26 May 2019 15:03:34 +0300 MIME-Version: 1.0 In-Reply-To: <148cfacb-757b-0c4a-7b7d-efaa18c6ffac@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org >> diff --git a/src/box/ck_constraint.c b/src/box/ck_constraint.c >> index 43798be76..4756f7970 100644 >> --- a/src/box/ck_constraint.c >> +++ b/src/box/ck_constraint.c >> @@ -46,17 +46,21 @@ const char *ck_constraint_language_strs[] = {"SQL"}; >> * tree traversal. >> * @param ck_constraint Check constraint object to update. >> * @param space_def Space definition to use. >> + * @param column_mask[out] The "smart" column mask of fields are >> + * referenced by AST. >> * @retval 0 on success. >> * @retval -1 on error. >> */ >> static int >> ck_constraint_resolve_field_names(struct Expr *expr, >> - struct space_def *space_def) >> + struct space_def *space_def, >> + uint64_t *column_mask) >> { >> struct Parse parser; >> sql_parser_create(&parser, sql_get(), default_flags); >> parser.parse_only = true; >> - sql_resolve_self_reference(&parser, space_def, NC_IsCheck, expr, NULL); >> + sql_resolve_self_reference(&parser, space_def, NC_IsCheck, expr, NULL, >> + column_mask); > > 2. Next to last argument 'expr_list' is always NULL. Please, drop it. I still do not see that argument dropped.