From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 82B2B45C304
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 11 Dec 2020 18:25:36 +0300 (MSK)
References: <848e5b2fe5d1b8da491759a07abc035142280638.1607638829.git.lvasiliev@tarantool.org>
 <75697D98-9AA4-42DE-BF05-BADD3CEF4520@tarantool.org>
From: Leonid Vasiliev <lvasiliev@tarantool.org>
Message-ID: <d785f5dc-c72f-7ffb-6c96-d3edbb46e50a@tarantool.org>
Date: Fri, 11 Dec 2020 18:24:38 +0300
MIME-Version: 1.0
In-Reply-To: <75697D98-9AA4-42DE-BF05-BADD3CEF4520@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH] sql: increase default cache size
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org


Hi! Thank you for the review.

On 11.12.2020 17:12, Sergey Ostanevich wrote:
> Hi!
> 
> Thanks for the patch! Since the memory allocation is done on per-request
> basis, there’s no impact on the memory consumption beyond these requests.
> Still it gives a real boost, so LGTM.
> 
> Create follow-up ticket to provide a user-visible runtime option under
> box.cfg
> 

The ticket already exists, the patch is part of this ticket (does not
close it).

> Sergos
> 
> 
> 
>> On 11 Dec 2020, at 01:37, Leonid Vasiliev <lvasiliev@tarantool.org> wrote:
>>
>> Increase the maximum number of in-memory pages to use
>> for temporary tables.
>> (https://www.sqlite.org/compile.html#default_cache_size)
>>
>> Part of #5609
>> ---
>>
>> Hi SQL team. It is a simplest part of #5609.
>> This patch increases the default SQL cache size by 10 times to 20 MB.
>> A similar experiment shows a 10% performance increase for some datasets.
>> (https://github.com/tarantool/tarantool/issues/5593#issuecomment-740044007).
>> Mons approved these changes. I haven't done any research to determine the
>> optimal value. So feel free to throw this patch away.
>>
>> https://github.com/tarantool/tarantool/issues/5609
>> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-5609-increase-default-sql-sort-cache-size
>>
>> src/box/CMakeLists.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/src/box/CMakeLists.txt b/src/box/CMakeLists.txt
>> index 19203f7..7372179 100644
>> --- a/src/box/CMakeLists.txt
>> +++ b/src/box/CMakeLists.txt
>> @@ -218,6 +218,10 @@ if(CMAKE_BUILD_TYPE STREQUAL "Debug")
>>    add_definitions(-DSQL_DEBUG=1)
>> endif()
>> add_definitions(-DSQL_TEST=1)
>> +# Set the maximum number of in-memory pages to use for temporary tables.
>> +# 20000 * 1024 = 20480000 bytes.
>> +# (https://www.sqlite.org/compile.html#default_cache_size)
>> +add_definitions(-DSQL_DEFAULT_CACHE_SIZE=-20000)
>>
>> set(EXT_SRC_DIR ${CMAKE_SOURCE_DIR}/extra)
>> set(EXT_BIN_DIR ${CMAKE_BINARY_DIR}/extra)
>> -- 
>> 2.7.4
>>
>