From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1F8764696C4
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  6 Apr 2020 00:22:35 +0300 (MSK)
References: <cover.1585954493.git.sergepetrenko@tarantool.org>
 <9042734e4ddc49d2e8903b346b84d699d1e2c46b.1585954493.git.sergepetrenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <d749e0a6-56d8-d33f-f304-6a04607030f3@tarantool.org>
Date: Sun, 5 Apr 2020 23:22:32 +0200
MIME-Version: 1.0
In-Reply-To: <9042734e4ddc49d2e8903b346b84d699d1e2c46b.1585954493.git.sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/4] uuid: expose additional
 from_string constructors
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for the patch!

> diff --git a/src/lib/uuid/tt_uuid.c b/src/lib/uuid/tt_uuid.c
> index 1bd2e2cfe..94a0b15bb 100644
> --- a/src/lib/uuid/tt_uuid.c
> +++ b/src/lib/uuid/tt_uuid.c
> @@ -65,6 +65,15 @@ tt_uuid_create(struct tt_uuid *uu)
>  }
>  #endif
>  
> +extern inline int

'inline' modifier won't change anything. The function body is
not visible anyway.

> +tt_uuid_validate(struct tt_uuid *uu);
> +
> +extern inline int
> +tt_uuid_from_fmt_string(const char *in, struct tt_uuid *uu, const char *fmt);
> +
> +extern inline int
> +tt_uuid_from_lstring(const char *in, uint32_t len, struct tt_uuid *uu);
> +
>  extern inline int
>  tt_uuid_from_string(const char *in, struct tt_uuid *uu);
>  

There are unit tests for uuid in unit/uuid.c. You may need to
add tests for the new functions.