From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 40B8046970F
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 27 Nov 2019 00:03:25 +0300 (MSK)
References: <a9d19273e8103ffd8ac07ced93a8b97dff770417.1574782721.git.imun@tarantool.org>
 <20191126165407.ncmd7hepnpifgv6v@tkn_work_nb>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <d71f8997-832e-3dc3-8c84-1ec8bb217908@tarantool.org>
Date: Tue, 26 Nov 2019 22:03:23 +0100
MIME-Version: 1.0
In-Reply-To: <20191126165407.ncmd7hepnpifgv6v@tkn_work_nb>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] test: adjust the test name related
 to PAIRSMM flag
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>, Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

On 26/11/2019 17:54, Alexander Turenko wrote:
> On Tue, Nov 26, 2019 at 06:47:38PM +0300, Igor Munkin wrote:
>> The prior name doesn't respect the naming convention used by test-run
>> thus this chunk was ignored by our testing machinery.
>>
>> Part-of tarantool/tarantool#4560
>>
>> Signed-off-by: Igor Munkin <imun@tarantool.org>
>> ---
>>
>> Branch: https://github.com/tarantool/luajit/tree/imun/test-name-fixup
>> Issue: https://github.com/tarantool/tarantool/issues/4560
>>
>>
>>  test/{mmpairs_test.lua => mmpairs-tarantool-4560.test.lua} | 0
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>  rename test/{mmpairs_test.lua => mmpairs-tarantool-4560.test.lua} (100%)
>>
>> diff --git a/test/mmpairs_test.lua b/test/mmpairs-tarantool-4560.test.lua
>> similarity index 100%
>> rename from test/mmpairs_test.lua
>> rename to test/mmpairs-tarantool-4560.test.lua

We have already agreed on, and use a different test name pattern:

    gh-####-description.test.lua

Not

    <description>-####.test.lua.