From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 706956EC5B; Tue, 30 Mar 2021 01:19:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 706956EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617056354; bh=8qMaQD68kztn0H0UYxVuWI1h+XQ3R9H4QF9gjMQMW5I=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Y0GlwByQxBk/Y0sgqzEq3mHG/NTXTA9MJH5GFGPwvzzSrMKteootttxJxtNmZjwDW j084RujsSwzMsOXB1fDmjPh9rjq4HaPpwPABfPTbDvVHf5rIo9xFxIVDmu3fQ7mYXn esyvtDuKftrC3SWYoH7sHHdc0V2z38SqBME9evno= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D13D96EC5B for ; Tue, 30 Mar 2021 01:19:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D13D96EC5B Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lR0E3-0001D3-N1; Tue, 30 Mar 2021 01:19:12 +0300 To: Cyrill Gorcunov References: <20210327111310.37504-1-gorcunov@gmail.com> <20210327111310.37504-3-gorcunov@gmail.com> Message-ID: Date: Tue, 30 Mar 2021 00:19:10 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F5380850408BFB69588D8A479471E743829EDA28FB54DE40B610494F4B0F2F138DD67C6F68 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70386A6136E33FD82EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637782358EF9635990EEA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664AF392B77D6B6B38103F52D3B43FA301CE5DA9B6D6F51F3D8389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C08794E14F7ADDB10D8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B69EAAB76869E07C3ECC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89FC0F9454058DFE53C262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831D9824B4288B53759916D7973594ED144 X-C1DE0DAB: 0D63561A33F958A5E0381A57036578E3D9C7747551F710A7571EC30B17E05690D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F1ADD4D8CD3C81CE4A396C80F5583E38A05F243D93C6AFE098C5B6179BBEC9BAFCA7C7D5754F0BDE1D7E09C32AA3244C94DA3C0329616DB68BD4D7BB58D3DAA133C9DC155518937F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rTwLhRt9UPmYA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822AD52DF37721B30D7463DAE644A1A248E3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 29.03.2021 23:57, Cyrill Gorcunov wrote: > On Mon, Mar 29, 2021 at 11:54:45PM +0200, Vladislav Shpilevoy wrote: >> Hi! Thanks for the fixes! >> >> Please, don't try to rush and answer my comments immediately after >> I send them. Even if they seem trivial. It won't speed the things >> up, and you will simply miss something, as I told many times. >> >> You still left 3 usages of 'is_paused == false', even though >> I specifically said this is the most confusing one. > > I need to make sure the .is_paused is false, the assert(x == false) > looks exactly what is needed. and we have similar code in our other > tests, do you prefer assert(not x.is_paused) or what? And there is much much much more tests using the booleans as they are supposed to be used. Why do you need exactly 'false' as a literal?