From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 1/2] swim: add SO_BROADCAST option Date: Fri, 19 Mar 2021 00:18:46 +0100 [thread overview] Message-ID: <d64c834a-8edc-10eb-90af-1ce37bd5dde3@tarantool.org> (raw) In-Reply-To: <YFPFuYvpacJmkpFA@grain> I force updated the patch on the branch. Could you please check if it works on your machine? For example, this test: uuid = require('uuid') swim = require('swim') s = swim.new({uuid = uuid(), uri = '127.0.0.1:3313'}) s:broadcast(3313) On Mac it used to print EADDRNOTAVAIL message. Probably would fail with something on Linux too, but I don't know. Might just work fine as well. ==================== diff --git a/src/lib/swim/swim_io.c b/src/lib/swim/swim_io.c index 45df36ba4..c3fca3d7f 100644 --- a/src/lib/swim/swim_io.c +++ b/src/lib/swim/swim_io.c @@ -513,7 +513,7 @@ swim_complete_send(struct swim_scheduler *scheduler, struct swim_task *task, ssize_t size) { if (size < 0) { - bool is_critical = false; + bool is_critical = true; #if TARGET_OS_DARWIN /* * On Mac this error happens regularly if SWIM is bound to @@ -524,7 +524,7 @@ swim_complete_send(struct swim_scheduler *scheduler, struct swim_task *task, * is not supposed to be used in prod. */ struct error *last = diag_last_error(diag_get()); - is_critical = (last->saved_errno == EADDRNOTAVAIL); + is_critical = (last->saved_errno != EADDRNOTAVAIL); #endif if (is_critical) diag_log();
next prev parent reply other threads:[~2021-03-18 23:18 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-18 0:02 [Tarantool-patches] [PATCH 0/2] Swim broadcast errors Vladislav Shpilevoy via Tarantool-patches 2021-03-18 0:02 ` [Tarantool-patches] [PATCH 1/2] swim: add SO_BROADCAST option Vladislav Shpilevoy via Tarantool-patches 2021-03-18 0:49 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-18 19:37 ` Cyrill Gorcunov via Tarantool-patches 2021-03-18 20:47 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-18 21:27 ` Cyrill Gorcunov via Tarantool-patches 2021-03-18 22:34 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-18 23:18 ` Vladislav Shpilevoy via Tarantool-patches [this message] 2021-03-19 6:53 ` Cyrill Gorcunov via Tarantool-patches 2021-03-19 20:18 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-19 20:29 ` Cyrill Gorcunov via Tarantool-patches 2021-03-19 21:46 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-19 22:15 ` Cyrill Gorcunov via Tarantool-patches 2021-03-18 0:02 ` [Tarantool-patches] [PATCH 2/2] lua: separate sched and script diag Vladislav Shpilevoy via Tarantool-patches 2021-03-19 13:17 ` [Tarantool-patches] [PATCH 0/2] Swim broadcast errors Serge Petrenko via Tarantool-patches 2021-03-19 22:37 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d64c834a-8edc-10eb-90af-1ce37bd5dde3@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/2] swim: add SO_BROADCAST option' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox